-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid surprising mutation and remove Any from the kwargs type. #6
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
from requests.auth import HTTPBasicAuth | ||
|
||
from ape_pie import APIClient | ||
from ape_pie.typing import RequestKwargs | ||
|
||
|
||
@pytest.mark.parametrize("attr", Session.__attrs__) | ||
|
@@ -32,9 +33,30 @@ def test_can_override_defaults(attr, value): | |
assert attr in Session.__attrs__ | ||
vanilla_session = Session() | ||
|
||
client = APIClient("https://example.com", {attr: value}) | ||
client = APIClient("https://example.com", {attr: value}) # type: ignore[assignment] | ||
|
||
vanilla_value = getattr(vanilla_session, attr) | ||
client_value = getattr(client, attr) | ||
assert client_value != vanilla_value | ||
assert client_value == value | ||
|
||
|
||
def test_config_does_not_mutate(): | ||
imported_settings: RequestKwargs = { | ||
"auth": ("djkhaled", "youplayedyourself"), | ||
} | ||
|
||
class MyConfig: | ||
@staticmethod | ||
def get_client_base_url(): | ||
return "https://example.com" | ||
|
||
@staticmethod | ||
def get_client_session_kwargs(): | ||
return imported_settings | ||
|
||
one = APIClient.configure_from(MyConfig) | ||
another_one = APIClient.configure_from(MyConfig) | ||
|
||
assert one.auth == ("djkhaled", "youplayedyourself") | ||
assert another_one.auth == ("djkhaled", "youplayedyourself") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After reading #3... Does this actually work? Or is this one of the surprises Victorien meant? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's a different thing. A surprising one indeed 😬 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose not to annotate
self._request_kwargs
asRequestKwargs
, because mypy only allows assignment in it with literals. The fact thatk
came from the same type...PyRight either is smarter or doesn't seem to mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with switching to pyright in CI instead of mypy if that makes life better