Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid surprising mutation and remove Any from the kwargs type. #6

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Avoid surprising mutation and remove Any from the kwargs type. #6

merged 3 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. 🏷️ Elminiate an Any 

    Use the types-requests stubs to annotate the kwargs.
Ideally we don't import _Names from a stub namespace but let the type
checker infer the ParamSpec.kwargs from its use. But ParamSpec can't be
used as where a Type is expected.
    @CharString
    CharString committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cab734a View commit details
    Browse the repository at this point in the history

  2. 🐛 Avoid mutation surprises

    @CharString
    CharString committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b75aea0 View commit details
    Browse the repository at this point in the history

  3. 👷 Run isort and mypy on just {src, tests} 

    Was already like this for black.
Running tox locally with a local venv in the project directory was failing
(and taking unnecessarily long)... Actually still does:
flake8 + isort + black > uv  😉
    @CharString
    CharString committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2da8590 View commit details
    Browse the repository at this point in the history