Make approval of imported entities work & other improvements #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the alert into the footer component, it was duplicated for each entity type.
* Replace "mdOffset", "justified" and "condensed" attributes. * "default" is not a valid variant, other cancel buttons use "secondary"
Copied from the other controllers...
The ORM functions have been changed to return the Bookshelf model.
This was referenced Jul 15, 2024
MonkeyDo
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1096
(Similar adjustments might be necessary for the other entity types, but currently we are only importing authors)
The changes in 1434038 and f289c71 may have not been relevant in the end, but I spotted these inconsistencies before I fixed the real issues in the ORM.