Create mondo-nando.sssom.tsv
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
commented
May 16, 2024
joeflack4
added
enhancement
joeflack4
reviewed
May 16, 2024
joeflack4
force-pushed
the
nando-mapping-set
branch
from
68067ed
to
10bf971
Compare
joeflack4
reviewed
May 16, 2024
matentzn
commented
May 17, 2024
|
Thanks @joeflack4 some minor suggestions but looks good! |
matentzn
commented
May 17, 2024
joeflack4
reviewed
May 17, 2024
matentzn
commented
May 19, 2024
joeflack4
reviewed
May 20, 2024
matentzn
commented
May 31, 2024
joeflack4
reviewed
May 31, 2024
- Add: ROBOT template for NanDO mappings - Update: Make goal for creating NanDO ROBOT template General - Add: Script for converting SSSOM to ROBOT template
Refactor future proof for potential future edge case bug Co-authored-by: Nico Matentzoglu <[email protected]>
Updated header field ORCID --> author_id, for consistency and correctness Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
SSSOMtoROBOT - Bug fix: Column order was preventing axiom annotations from being correctly applied/linked. - Add: mapping_provider - Add: More skos -> MONDO mapping predicates
Changed make to $(MAKE) for consistency
Corrected a robot subheader Co-authored-by: Nico Matentzoglu <[email protected]>
joeflack4
force-pushed
the
nando-mapping-set
branch
from
1d2ca97
to
80a00ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also addresses monarch-initiative/mondolib#11
This PR adds the manually curated SSSOM mappings between Nando and Mondo to the Mondo ingest.
This is needed for the Rare Disease Paper. To take the pressure of this PR, I will use a manual translation to proceed, but this still needs to be done at some point before the paper is submitted (which is soon, not sure how soon)
Overview
This PR:
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Build PR:
mondo-nando.sssom.tsv- build #552Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?