Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mondo-nando.sssom.tsv - build #552

Closed
wants to merge 17 commits into from

Conversation

joeflack4
Copy link
Contributor

Build / data files PR for:

matentzn and others added 17 commits May 16, 2024 16:25
- Add: ROBOT template for NanDO mappings
- Update: Make goal for creating NanDO ROBOT template

General
- Add: Script for converting SSSOM to ROBOT template
Refactor future proof for potential future edge case bug

Co-authored-by: Nico Matentzoglu <[email protected]>
Updated header field ORCID --> author_id, for consistency and correctness

Co-authored-by: Nico Matentzoglu <[email protected]>
SSSOMtoROBOT
- Bug fix: Column order was preventing axiom annotations from being correctly applied/linked.
- Add: mapping_provider
- Add: More skos -> MONDO mapping predicates
Changed make to $(MAKE) for consistency
Corrected a robot subheader

Co-authored-by: Nico Matentzoglu <[email protected]>
@joeflack4 joeflack4 added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Jun 1, 2024
@joeflack4 joeflack4 assigned matentzn and joeflack4 and unassigned matentzn Jun 1, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build PR

@matentzn @twhetzel It passed without failure. However I won't have time to review this until Tuesday probably. If you guys have time before then, feel free to look at the outputs and see if it looks good.

@joeflack4 joeflack4 mentioned this pull request Jun 1, 2024
9 tasks
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thats all we need to check here

Base automatically changed from nando-mapping-set to develop June 5, 2024 17:34
@joeflack4 joeflack4 closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants