Makefile fixed for nexys emulation target #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Martin <[email protected]>
There was a problem hiding this comment.
Hi @gmartin102. I am not clear on why the pad_mux has been changed.
| assign perio_in_o[14] = ((pad_mux_i[29] == 2'd1) ? io_in_i[29] : 1'b1); | ||
| assign perio_in_o[15] = ((pad_mux_i[33] == 2'd1) ? io_in_i[33] : 1'b1); | ||
| assign perio_in_o[16] = ((pad_mux_i[34] == 2'd1) ? io_in_i[34] : 1'b1); | ||
| assign perio_in_o[13] = ((pad_mux_i[40] == 2'd1) ? io_in_i[40] : 1'b1); |
There was a problem hiding this comment.
I was not expecting to see changes to the pad_mux in this PR.
|
Closing on recommendation from @gmartin102. |
|
The Makefile still has the wrong top level name at line 137. The change to the Makefile is still useful. Is there another pull request to fix this? |
We would review a PR that goes this if you'd like to submit one. Please review CONTRIBUTING before you do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the name on the auto generated top level. during testing I had changed the name to prevent overwriting of the top level. Once done testing I failed to return it to correct behavior. My builds were passing due to a stale file with the correct name on the system.This addresses issue #323