Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RVFI updates for pulp post increment load instr, all CSR updates for FPU instructions and some general improvements #856

Merged
merged 9 commits into from
Aug 24, 2023

Conversation

dd-vaibhavjain
Copy link

This PR is for updaing RVFI for issues seen during simulations

  1. Fix for post-increment loads - use trace * m_rd_addr[0], m_rd_wdata[0] ,i.e, index 0 for any reg file updates from ALU for instructions with multiple register updates such as post increment loads.
  2. Clean trace_wb to only move load instructions to this wb trace structure.
  3. Fix FCSR updates to ensure this register update are captured for both APU instructions and explicit CSR updates. And also update fflags and frm CSRs accordingly.
  4. Add logic to check for mstatus FS and SD fields update from FPU instructions.
  5. Add INIT_CSR macro and corresponding function init_csr() for insn_trace to ensure each new object has a clean CSR values. Thus to ensure clean CSR update status for each instruction and also simplify debugging for CSR update issues for RVFI and reference model.
  6. Check got_mistret flag is set or not before updating mistret csr from EX stage to avoid multiple updates to the CSR from ID and EX stage.

Signed-off-by: Vaibhav Jain <[email protected]>
@pascalgouedo pascalgouedo added the Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) label Aug 23, 2023
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I am not sufficiently familar with the implementation of the RFVI Tracer to offer a valid technical opinion about the changes. I will request a review from @davideschiavone.

Copy link
Contributor

@YoannPruvost YoannPruvost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me!

@davideschiavone davideschiavone merged commit 0b47ca4 into openhwgroup:dev Aug 24, 2023
1 check passed
@dd-vaibhavjain dd-vaibhavjain deleted the dev_vja_rvfi_update branch August 24, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants