-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RVFI updates for pulp post increment load instr, all CSR updates for FPU instructions and some general improvements #856
RVFI updates for pulp post increment load instr, all CSR updates for FPU instructions and some general improvements #856
Conversation
Signed-off-by: Vaibhav Jain <[email protected]>
…'s rd registers always at index 0 or rd[0] Signed-off-by: Vaibhav Jain <[email protected]>
Signed-off-by: Vaibhav Jain <[email protected]>
Signed-off-by: Vaibhav Jain <[email protected]>
Signed-off-by: Vaibhav Jain <[email protected]>
Signed-off-by: Vaibhav Jain <[email protected]>
…s clean Signed-off-by: Vaibhav Jain <[email protected]>
…et based on a new instr Signed-off-by: Vaibhav Jain <[email protected]>
Signed-off-by: Vaibhav Jain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I am not sufficiently familar with the implementation of the RFVI Tracer to offer a valid technical opinion about the changes. I will request a review from @davideschiavone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me!
This PR is for updaing RVFI for issues seen during simulations