-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RTL LINT scripts. #931
add RTL LINT scripts. #931
Conversation
Signed-off-by: Pascal Gouedo <[email protected]>
scripts/lint/cv32e40p_wrapper.sv
Outdated
@@ -0,0 +1,113 @@ | |||
// Copyright 2018 ETH Zurich and University of Bologna. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add OpenHW Group license please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a general topic I wanted to discuss with @MikeOpenHWGroup and you.
None of the RTL files have OpenHW group license, only BHV ones have it.
And RTL headers are not coherent between themselves.
I think we should discuss about that, decide about a rule and create a specific PR just for that subject.
I am going to use this file to propose something.
For each file, we can add all contributors already listed in and keep original file description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @pascalgouedo, you are right that we are not consistent in the way we manage license header files. It is my understanding that for any file that are substantially modified, a new copyright may be added, but the existing copyright and license header must not be removed or modified.
Usually I will do this with a one-line SPDX header. For example:
// Copyright 2024 OpenHW Group and <member co.>
// SPDX-License-Identifier: Apache-2.0 WITH SHL-2.1
// Copyright 2018 ETH Zurich and University of Bologna.
// ...original license header from ETHZ and UniBo.
I have created pull-request #934 and we can discuss this idea there (without blocking this PR).
Signed-off-by: Pascal Gouedo <[email protected]>
As per discussion in pull-request openhwgroup#931.
Signed-off-by: Pascal Gouedo <[email protected]>
No description provided.