-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example for updating copyright and license header #934
Add an example for updating copyright and license header #934
Conversation
[Skip CI] Version 2 RTD configuration file
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Explicit build.os is now required by RTD.
…ld.os Update .readthedocs.yaml
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
Automatic PR dev->master
As per discussion in pull-request openhwgroup#931.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending of the files, this is creating a sandwich of different layers which makes it awful to see !!!
All files have the same SHL license. If for each file we keep all previous information but restructured in a common way, I think this should not be a pb.
Some of them have Silabs, some of them ETH, others Bologna only.
I would propose ETH, Bologna, Silabs, Dolphin Design and OpenHW for all RTL files.
Plus keeping already listed contributors file per file.
Yes, I agree. I have seen some truly ugly open-source license headers! This is why I suggest adding only two lines, one for the copyright and a second for the SPDX license. That adds only two lines per contributor, and if the license does not change then only one line. |
Doesn't really answer to the original point of cleaning up... |
I presume you mean this point:
Agree and understood. If we agree on the the method for updating copyright and license headers, the next step is to update all the RTL. I leave this to you, @davideschiavone and maybe @Silabs-ArjanB. |
I will propose what I have in mind through a specific PR for all RTL files. |
@MikeOpenHWGroup @pascalgouedo @davideschiavone the difficulty I have is that it is very hard to see who is contributing what with multiple authors presented in the same header. In other words, member A contributes something under License 1. Member B then contributes something additional under License 2. Not sure, but I think they should have separate headers with a description of what has been added. Otherwise it is impossible to see who is asserting what rights and granting what licenses to copyrights and patents. Let me check with Eclipse guys. |
My proposal already adds a legal and complete license header (that this the comment line starting with SPDX). The description of what has been added is taken care of by the git/GitHub revision history and record of pull-request. No need to repeat that in a comment header. |
I think that from a license point of view, files should be self-sufficient without relying on any file management history. |
As per discussion in pull-request #931.