Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug module parameterization #1382

Merged

Conversation

zarubaf
Copy link
Contributor

@zarubaf zarubaf commented Sep 11, 2023

The debug module address was hard-coded which leads to a mismatch with a newer version of the debug module (since this commit pulp-platform/riscv-dbg@55cda4b).

To avoid that in the future and to avoid dependencies on the debug module the debug module addresses can be passed as a parameter of CVA6Cfg now. I've also moved the ariane_dm_pkg constants into ariane_pkg to get rid of this module.

@zarubaf
Copy link
Contributor Author

zarubaf commented Sep 11, 2023

@JeanRochCoulon how can I re-generate all configurations with the new config parameters?

@JeanRochCoulon
Copy link
Contributor

Hi Florian, the configurations are setup in core/include/cvXXXXXXX_config_pkg.sv. You can add the new parameters to the cva6_cfg struct which is defined inside.

@zarubaf
Copy link
Contributor Author

zarubaf commented Sep 11, 2023

Hi Florian, the configurations are setup in core/include/cvXXXXXXX_config_pkg.sv. You can add the new parameters to the cva6_cfg struct which is defined inside.

Is that a manual process? I thought I could use the package Generation script 🙈

@JeanRochCoulon
Copy link
Contributor

Yes, manual :-(

@github-actions
Copy link
Contributor

❌ failed run, report available here.

@zarubaf zarubaf changed the title Draft: Fix debug module parameterization Fix debug module parameterization Sep 13, 2023
@zarubaf zarubaf force-pushed the zarubaf/fix/dm-parameterization branch from bd1991c to 1c3bde4 Compare September 13, 2023 07:06
@github-actions
Copy link
Contributor

❌ failed run, report available here.

@zarubaf
Copy link
Contributor Author

zarubaf commented Sep 13, 2023

@JeanRochCoulon should be ready now for review. Thanks

@JeanRochCoulon JeanRochCoulon merged commit 91df628 into openhwgroup:master Sep 13, 2023
6 checks passed
@JeanRochCoulon
Copy link
Contributor

Thanks @zarubaf
Parametrization is not finished but we go ahead !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants