Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable turbo drive #16486

Draft
wants to merge 48 commits into
base: dev
Choose a base branch
from
Draft

Enable turbo drive #16486

wants to merge 48 commits into from

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Aug 20, 2024 •
edited by ulferts
Loading

https://community.openproject.org/work_packages/57270

Known issues

  • Backlogs is not re-initialized on turbo

Known broken tests

  • ./modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb
  • ./modules/bim/spec/features/bcf/api_authorization_spec.rb
  • ./modules/bim/spec/features/card_view/bulk_actions_spec.rb
  • ./modules/boards/spec/features/action_boards/assignee_board_spec.rb
  • ./modules/boards/spec/features/action_boards/custom_field_filters_spec.rb
  • ./modules/boards/spec/features/action_boards/status_board_spec.rb
  • ./modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb
  • ./modules/boards/spec/features/action_boards/subproject_board_spec.rb
  • ./modules/boards/spec/features/action_boards/subtasks_board_spec.rb
  • ./modules/boards/spec/features/action_boards/version_board_spec.rb
  • ./modules/boards/spec/features/board_highlighting_spec.rb
  • ./modules/boards/spec/features/board_management_spec.rb
  • ./modules/boards/spec/features/board_navigation_spec.rb
  • ./modules/boards/spec/features/boards_global_create_spec.rb
  • ./modules/calendar/spec/features/calendars_global_create_spec.rb
  • ./modules/meeting/spec/features/meetings_close_spec.rb
  • ./modules/meeting/spec/features/meetings_index_spec.rb
  • ./modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb
  • ./modules/storages/spec/features/manage_project_storage_spec.rb
  • ./modules/team_planner/spec/features/team_planner_global_create_spec.rb
  • ./spec/features/admin/attribute_help_texts_spec.rb
  • ./spec/features/admin/enterprise/enterprise_spec.rb
  • ./spec/features/auth/consent_auth_stage_spec.rb
  • ./spec/features/auth/logout_spec.rb
  • ./spec/features/forums/attachment_upload_spec.rb
  • ./spec/features/menu_items/wiki_menu_item_spec.rb
  • ./spec/features/oauth/authorization_code_flow_spec.rb
  • ./spec/features/placeholder_users/index_spec.rb
  • ./spec/features/projects/attribute_help_texts_spec.rb
  • ./spec/features/projects/projects_index_spec.rb
  • ./spec/features/types/form_configuration_query_spec.rb
  • ./spec/features/types/form_configuration_spec.rb
  • ./spec/features/types/reset_form_configuration_spec.rb
    • The specs are fixed but the component is initialized twice which can also lead to the form configuration not working again. That could also be caused by the ckeditor on a different tab (types/:id/edit/settings) failing.
  • ./spec/features/users/delete_spec.rb
  • ./spec/features/users/index_spec.rb
  • ./spec/features/work_packages/bulk/copy_work_package_spec.rb
  • ./spec/features/work_packages/bulk/move_work_package_spec.rb
  • ./spec/features/work_packages/cancel_editing_spec.rb
  • ./spec/features/work_packages/share/share_account_activation_spec.rb
  • ./spec/features/work_packages/update_ancestors_spec.rb
  • ./spec/features/wysiwyg/macros/code_block_macro_spec.rb
  • ./spec/features/wysiwyg/macros/embedded_tables_spec.rb

@oliverguenther oliverguenther force-pushed the experiment/enable-turbo-drive branch 2 times, most recently from e441bc1 to f89c2c8 Compare August 28, 2024 13:04
@oliverguenther oliverguenther force-pushed the experiment/enable-turbo-drive branch 7 times, most recently from e01058b to c65b3de Compare September 17, 2024 07:11
@oliverguenther oliverguenther force-pushed the experiment/enable-turbo-drive branch 4 times, most recently from b8ea12e to c78fb7f Compare October 11, 2024 05:37
oliverguenther and others added 11 commits October 18, 2024 08:31
@oliverguenther
Extend spec to use target=_top
af4a707
@oliverguenther
compact on roles
98d92b4 
Local prevention of this error

     NoMethodError:
       undefined method `instantiate' for nil
     Shared Example Group: "a meetings tab" called from
./modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb:463
     # ./app/models/custom_actions/conditions/role.rb:44:in `flatten'
@oliverguenther
Reload attribute help texts to update previews
1ccb13b
@oliverguenther
wait for network_idle on logout_spec
df2ec4e
@oliverguenther
Fix forum upload spec
e8b26ed 
with turbo: false, the form does not correctly get replaced in the current implementation,
brekaing tests on upload attachment counting.
@oliverguenther
Wait for idle
aa62d9c
@ulferts
Merge remote-tracking branch 'origin/dev' into experiment/enable-turb…
d5b6f91 
…o-drive
@ulferts
adapt secure_headers patched version
6fe6bf0
@ulferts
wait for network on user index tests
4ed3468
@ulferts
fix spec by adding a success flash semaphore
7e70cb5
@ulferts
properly destroy form configuration component
7c3f6a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @ulferts