Enable turbo drive

app/controllers/account_controller.rb

@@ -377,40 +377,44 @@
     end
   end
 
   def password_authentication(username, password)
     user = User.try_to_login(username, password, session)
     if user.nil?
       # login failed, now try to find out why and do the appropriate thing
       user = User.find_by_login(username)
       if user and user.check_password?(password)
         # correct password
         if not user.active?
           account_inactive(user, flash_now: true)
+          render status: :unprocessable_entity
         elsif user.force_password_change
           return if redirect_if_password_change_not_allowed(user)
 
           render_password_change(user, I18n.t(:notice_account_new_password_forced), show_user_name: true)
         elsif user.password_expired?
           return if redirect_if_password_change_not_allowed(user)
 
           render_password_change(user, I18n.t(:notice_account_password_expired, days: Setting.password_days_valid.to_i),
                                  show_user_name: true)
         else
           flash_and_log_invalid_credentials
+          render status: :unprocessable_entity
         end
       elsif user and user.invited?
         invited_account_not_activated(user)
+        render status: :unprocessable_entity
       else
         # incorrect password
         flash_and_log_invalid_credentials
+        render status: :unprocessable_entity
       end
     elsif user.new_record?
       onthefly_creation_failed(user, login: user.login, ldap_auth_source_id: user.ldap_auth_source_id)
     else
       # Valid user
       successful_authentication(user)
     end
   end
 
   def invited_account_not_activated(_user)
     flash_error_message(log_reason: "invited, NOT ACTIVATED", flash_now: false) do

app/controllers/angular_controller.rb

@@ -34,7 +34,11 @@ class AngularController < ApplicationController
   def empty_layout
     # Frontend will handle rendering
     # but we will need to render with layout
-    render html: "", layout: "angular/angular"
+    respond_to do |format|
+      format.html do
+        render html: "", layout: "angular/angular"
+      end
+    end
   end
 
   def login_back_url_params

app/controllers/attribute_help_texts_controller.rb

@@ -44,34 +44,34 @@
 
   def edit; end
 
   def create
     call = ::AttributeHelpTexts::CreateService
       .new(user: current_user)
       .call(permitted_params_with_attachments)
 
     if call.success?
       flash[:notice] = t(:notice_successful_create)
       redirect_to attribute_help_texts_path(tab: call.result.attribute_scope)
     else
       @attribute_help_text = call.result
-      flash[:error] = call.message || I18n.t("notice_internal_server_error")
-      render action: "new"
+      flash.now[:error] = call.message || I18n.t("notice_internal_server_error")
+      render action: "new", status: :unprocessable_entity
     end
   end
 
   def update
     call = ::AttributeHelpTexts::UpdateService
       .new(user: current_user, model: @attribute_help_text)
       .call(permitted_params_with_attachments)
 
     if call.success?
       flash[:notice] = t(:notice_successful_update)
       redirect_to attribute_help_texts_path(tab: @attribute_help_text.attribute_scope)
     else
-      flash[:error] = call.message || I18n.t("notice_internal_server_error")
-      render action: "edit"
+      flash.now[:error] = call.message || I18n.t("notice_internal_server_error")
+      render action: :edit, status: :unprocessable_entity
     end
   end
 
   def destroy
     if @attribute_help_text.destroy

app/controllers/categories_controller.rb

@@ -38,31 +38,31 @@
     @category = @project.categories.build
   end
 
   def create
     @category = @project.categories.build
     @category.attributes = permitted_params.category
 
     if @category.save
       respond_to do |format|
         format.html do
           flash[:notice] = I18n.t(:notice_successful_create)
           redirect_to project_settings_categories_path(@project)
         end
         format.js do
           render locals: { project: @project, category: @category }
         end
       end
     else
       respond_to do |format|
         format.html do
-          render action: :new
+          render action: :new, status: :unprocessable_entity
         end
         format.js do
           render(:update) { |page| page.alert(@category.errors.full_messages.join('\n')) }
         end
       end
     end
   end
 
   def update
     @category.attributes = permitted_params.category
@@ -70,7 +70,7 @@
       flash[:notice] = I18n.t(:notice_successful_update)
       redirect_to project_settings_categories_path(@project)
     else
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/colors_controller.rb

@@ -69,7 +69,7 @@ def create
       redirect_to colors_path
     else
       flash.now[:error] = I18n.t(:error_color_could_not_be_saved)
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -81,7 +81,7 @@ def update
       redirect_to colors_path
     else
       flash.now[:error] = I18n.t(:error_color_could_not_be_saved)
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/concerns/accounts/registration.rb

@@ -118,7 +118,7 @@ def respond_for_registered_user(user)
   def onthefly_creation_failed(user, auth_source_options = {})
     @user = user
     session[:auth_source_registration] = auth_source_options unless auth_source_options.empty?
-    render action: "register"
+    render action: "register", status: :unprocessable_entity
   end
 
   def self_registration_disabled

app/controllers/concerns/accounts/user_password_change.rb

@@ -65,7 +65,7 @@ def render_password_change(user, message, show_user_name: false)
     flash[:error] = message unless message.nil?
     @user = user
     @username = user.login
-    render "my/password", locals: { show_user_name: }
+    render "my/password", locals: { show_user_name: }, status: :unprocessable_entity
   end
 
   ##

app/controllers/concerns/custom_fields/shared_actions.rb

@@ -47,20 +47,20 @@
         end
       end
 
       def create
         call = ::CustomFields::CreateService
           .new(user: current_user)
           .call(get_custom_field_params.merge(type: permitted_params.custom_field_type))
 
         if call.success?
           flash[:notice] = t(:notice_successful_create)
           call_hook(:controller_custom_fields_new_after_save, custom_field: call.result)
           redirect_to index_path(call.result, tab: call.result.class.name)
         else
           @custom_field = call.result || new_custom_field
-          render action: "new"
+          render action: :new, status: :unprocessable_entity
         end
       end
 
       def update
         perform_update(get_custom_field_params)
@@ -76,7 +76,7 @@
           call_hook(:controller_custom_fields_edit_after_save, custom_field: @custom_field)
           redirect_back_or_default(edit_path(@custom_field, id: @custom_field.id))
         else
-          render action: "edit"
+          render action: :edit, status: :unprocessable_entity
         end
       end
 

app/controllers/custom_actions_controller.rb

@@ -77,7 +77,7 @@ def index_or_render(render_action)
 
       call.on_failure do
         @custom_action = call.result
-        render action: render_action
+        render action: render_action, status: :unprocessable_entity
       end
     }
   end

app/controllers/enterprises_controller.rb

@@ -47,28 +47,28 @@
     end
   end
 
   def create
     @token = EnterpriseToken.current || EnterpriseToken.new
     saved_encoded_token = @token.encoded_token
     @token.encoded_token = params[:enterprise_token][:encoded_token]
     if @token.save
       flash[:notice] = t(:notice_successful_update)
       respond_to do |format|
         format.html { redirect_to action: :show }
         format.json { head :no_content }
       end
     else
       # restore the old token
       if saved_encoded_token
         @token.encoded_token = saved_encoded_token
         @current_token = @token || EnterpriseToken.new
       end
       respond_to do |format|
-        format.html { render action: :show }
+        format.html { render action: :show, status: :unprocessable_entity }
         format.json { render json: { description: @token.errors.full_messages.join(", ") }, status: :bad_request }
       end
     end
   end
 
   def destroy
     token = EnterpriseToken.current

app/controllers/enumerations_controller.rb

@@ -58,7 +58,7 @@ def create
       flash[:notice] = I18n.t(:notice_successful_create)
       redirect_to action: "index", type: @enumeration.type
     else
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -70,7 +70,7 @@ def update
       flash[:notice] = I18n.t(:notice_successful_update)
       redirect_to enumerations_path(type: @enumeration.type)
     else
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 
@@ -96,7 +96,7 @@ def move
       redirect_to enumerations_path
     else
       flash.now[:error] = I18n.t(:error_type_could_not_be_saved)
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/forums_controller.rb

@@ -111,7 +111,7 @@ def move
       flash[:notice] = t(:notice_successful_update)
     else
       flash.now[:error] = t("forum_could_not_be_saved")
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
     redirect_to action: "index"
   end

app/controllers/groups_controller.rb

@@ -64,7 +64,7 @@ def create
       flash[:notice] = I18n.t(:notice_successful_create)
       redirect_to(groups_path)
     else
-      render action: :new
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -77,7 +77,7 @@ def update
       flash[:notice] = I18n.t(:notice_successful_update)
       redirect_to(groups_path)
     else
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/messages_controller.rb

@@ -89,7 +89,7 @@ def create
 
       redirect_to topic_path(@message)
     else
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -118,7 +118,7 @@ def update
       @message.reload
       redirect_to topic_path(@message.root, r: @message.parent_id && @message.id)
     else
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/news_controller.rb

@@ -82,7 +82,7 @@ def create
       redirect_to controller: "/news", action: "index", project_id: @project
     else
       @news = call.result
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -96,7 +96,7 @@ def update
       redirect_to action: "show", id: @news
     else
       @news = call.result
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/oauth/applications_controller.rb

@@ -61,7 +61,7 @@ def create
         redirect_to action: :show, id: result.id
       else
         @application = result
-        render action: :new
+        render action: :new, status: :unprocessable_entity
       end
     end
 
@@ -79,7 +79,7 @@ def update
         redirect_to action: :index
       else
         flash[:error] = call.errors.full_messages.join('\n')
-        render action: :edit
+        render action: :edit, status: :unprocessable_entity
       end
     end
 

app/controllers/placeholder_users_controller.rb

@@ -79,50 +79,50 @@
     @individual_principal = @placeholder_user
   end
 
   def create
     service = PlaceholderUsers::CreateService.new(user: User.current)
     service_result = service.call(permitted_params.placeholder_user)
     @placeholder_user = service_result.result
 
     if service_result.success?
       respond_to do |format|
         format.html do
           flash[:notice] = I18n.t(:notice_successful_create)
           redirect_to(params[:continue] ? new_placeholder_user_path : edit_placeholder_user_path(@placeholder_user))
         end
       end
     else
       respond_to do |format|
         format.html do
-          render action: :new
+          render action: :new, status: :unprocessable_entity
         end
       end
     end
   end
 
   def update
     service_result = PlaceholderUsers::UpdateService
       .new(user: User.current,
            model: @placeholder_user)
       .call(permitted_params.placeholder_user)
 
     if service_result.success?
       respond_to do |format|
         format.html do
           flash[:notice] = I18n.t(:notice_successful_update)
           redirect_back(fallback_location: edit_placeholder_user_path(@placeholder_user))
         end
       end
     else
       @membership ||= Member.new
 
       respond_to do |format|
         format.html do
-          render action: :edit
+          render action: :edit, status: :unprocessable_entity
         end
       end
     end
   end
 
   def deletion_info
     respond_to :html

app/controllers/projects/identifier_controller.rb

@@ -42,7 +42,7 @@ def update
       flash[:notice] = I18n.t(:notice_successful_update)
       redirect_to project_settings_general_path(@project)
     else
-      render action: "show"
+      render action: "show", status: :unprocessable_entity
     end
   end
 end

app/controllers/roles_controller.rb

@@ -65,7 +65,7 @@ def create
     else
       @roles = roles_scope
 
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -77,7 +77,7 @@ def update
       flash[:notice] = I18n.t(:notice_successful_update)
       redirect_to action: "index"
     else
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 
@@ -111,7 +111,7 @@ def bulk_update
     else
       @calls = calls
       @permissions = visible_permissions
-      render action: "report"
+      render action: "report", status: :unprocessable_entity
     end
   end
 

app/controllers/statuses_controller.rb

@@ -54,7 +54,7 @@ def create
       flash[:notice] = I18n.t(:notice_successful_create)
       redirect_to action: "index"
     else
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
@@ -65,7 +65,7 @@ def update
       flash[:notice] = I18n.t(:notice_successful_update)
       redirect_to action: "index"
     else
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 

app/controllers/types_controller.rb

@@ -60,23 +60,23 @@
     end
   end
 
   def create
     CreateTypeService
       .new(current_user)
       .call(permitted_type_params, copy_workflow_from: params[:copy_workflow_from]) do |call|
       @type = call.result
 
       call.on_success do
         redirect_to_type_tab_path(@type, t(:notice_successful_create))
       end
 
       call.on_failure do |result|
         flash[:error] = result.errors.full_messages.join("\n")
         load_projects_and_types
-        render action: "new"
+        render action: :new, status: :unprocessable_entity
       end
     end
   end
 
   def update
     UpdateTypeService
@@ -99,7 +99,7 @@
       redirect_to types_path
     else
       flash.now[:error] = I18n.t(:error_type_could_not_be_saved)
-      render action: "edit"
+      render action: :edit, status: :unprocessable_entity
     end
   end
 
@@ -144,7 +144,7 @@
     @projects = Project.all
     @type = type
 
-    render action: "edit"
+    render action: :edit, status: :unprocessable_entity
   end
 
   def show_local_breadcrumb

app/controllers/users_controller.rb

@@ -93,54 +93,54 @@
       flash[:notice] = I18n.t(:notice_successful_create)
       redirect_to(params[:continue] ? new_user_path : helpers.allowed_management_user_profile_path(@user))
     else
-      render action: "new"
+      render action: :new, status: :unprocessable_entity
     end
   end
 
   def update
     update_params = build_user_update_params
     call = ::Users::UpdateService.new(model: @user, user: current_user).call(update_params)
 
     if call.success?
       if update_params[:password].present? && @user.change_password_allowed?
         send_information = params[:send_information]
 
         if @user.invited?
           # setting a password for an invited user activates them implicitly
           if OpenProject::Enterprise.user_limit_reached?
             @user.register!
             show_user_limit_warning!
           else
             @user.activate!
           end
 
           send_information = true
         end
 
         if @user.active? && send_information
           UserMailer.account_information(@user, update_params[:password]).deliver_later
         end
       end
 
       respond_to do |format|
         format.html do
           flash[:notice] = I18n.t(:notice_successful_update)
-          render action: :edit
+          redirect_to action: :edit
         end
       end
     else
       @membership ||= Member.new
       # Clear password input
       @user = call.result
       @user.password = @user.password_confirmation = nil
 
       respond_to do |format|
         format.html do
-          render action: :edit
+          render action: :edit, status: :unprocessable_entity
         end
       end
     end
   end
 
   def change_status_info
     @status_change = params[:change_action].to_sym

app/controllers/versions_controller.rb

@@ -159,7 +159,7 @@ def render_cu(call, success_message, failure_action)
       flash[:notice] = t(success_message)
       redirect_back_or_version_settings
     else
-      render action: failure_action
+      render action: failure_action, status: :unprocessable_entity
     end
   end