Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable turbo drive #16486

Draft
wants to merge 48 commits into
base: dev
Choose a base branch
from
Draft

Enable turbo drive #16486

wants to merge 48 commits into from

Commits on Oct 8, 2024

  1. Allow running turbo drive with reusing nonces in secure headers

    @oliverguenther
    oliverguenther committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9f10cf3 View commit details
    Browse the repository at this point in the history

  2. sync ui-router on turbo visits

    @oliverguenther
    oliverguenther committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ca2f70b View commit details
    Browse the repository at this point in the history

  3. Bootstrap root component again on turbo load

    @oliverguenther
    oliverguenther committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    15de103 View commit details
    Browse the repository at this point in the history

  4. Setup listeners so that they run on turbo:load

    @oliverguenther
    oliverguenther committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7045e83 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Render with status: :unprocessable_entity

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fa99c5b View commit details
    Browse the repository at this point in the history

  2. Disable prefetch again 

    Prefetching breaks specs as they hit turbo_stream only requests
    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c7a208f View commit details
    Browse the repository at this point in the history

  3. Fix expectation

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e1dfb9b View commit details
    Browse the repository at this point in the history

  4. Wait for idle after sort

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8064695 View commit details
    Browse the repository at this point in the history

  5. Fix redirects, render with turbo in users controller

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    58de8c8 View commit details
    Browse the repository at this point in the history

  6. Fix top-menu not registered

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d79a587 View commit details
    Browse the repository at this point in the history

  7. Adapt password change spec

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c167eb5 View commit details
    Browse the repository at this point in the history

  8. Deal with no open dropdowns

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dd98d3d View commit details
    Browse the repository at this point in the history

  9. Fix en locale warning for ckeditor

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1b57502 View commit details
    Browse the repository at this point in the history

  10. Ensure we use respond_to 

    Otherwise, this breaks redireects from turbo, resulting in rendering
empty html without a layout
    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d267e85 View commit details
    Browse the repository at this point in the history

  11. Fix renders after redirect

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    47d62ba View commit details
    Browse the repository at this point in the history

  12. Wait for idle between login requests

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6eb4782 View commit details
    Browse the repository at this point in the history

  13. Close modals when turbo navigates

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5a31de4 View commit details
    Browse the repository at this point in the history

  14. Fix superfluous expect

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    caffdc6 View commit details
    Browse the repository at this point in the history

  15. Opt out of turbo for resend

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8a95295 View commit details
    Browse the repository at this point in the history

  16. Fix meeting spec

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    620e58a View commit details
    Browse the repository at this point in the history

  17. Disable turbo before redirect to index

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c4f06ab View commit details
    Browse the repository at this point in the history

  18. Replace subform

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1ea0dc7 View commit details
    Browse the repository at this point in the history

  19. Remove subform in cost types

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c0f149f View commit details
    Browse the repository at this point in the history

  20. Fix datepicker cloning

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0b29387 View commit details
    Browse the repository at this point in the history

  21. Disable turbo on new saml form

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    32b2f4e View commit details
    Browse the repository at this point in the history

  22. Fix registration spec using turbo

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bbd4001 View commit details
    Browse the repository at this point in the history

  23. Fix auth spec

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    07861d8 View commit details
    Browse the repository at this point in the history

  24. Clear cookies in cuprite correctly

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cf94d35 View commit details
    Browse the repository at this point in the history

  25. Fix bcf spec with cuprite

    @oliverguenther
    oliverguenther committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    26c0df0 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'dev' into experiment/enable-turbo-drive

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c5e4c7a View commit details
    Browse the repository at this point in the history

  2. Check for presence of form link

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9d1e54a View commit details
    Browse the repository at this point in the history

  3. Disable turbo after board creation

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9ccb841 View commit details
    Browse the repository at this point in the history

  4. Disable cuprite while dragging doesn't work reliably

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e8953e7 View commit details
    Browse the repository at this point in the history

  5. Remove duplicate opce-storage-login-button registration

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    570240b View commit details
    Browse the repository at this point in the history

  6. Use target: _top on meetings form

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e41456f View commit details
    Browse the repository at this point in the history

  7. redirect without turbo

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    fefe59b View commit details
    Browse the repository at this point in the history

  8. Target top on sort links

    @oliverguenther
    oliverguenther committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a4229e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Extend spec to use target=_top

    @oliverguenther
    oliverguenther committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    af4a707 View commit details
    Browse the repository at this point in the history

  2. compact on roles 

    Local prevention of this error

     NoMethodError:
       undefined method `instantiate' for nil
     Shared Example Group: "a meetings tab" called from
./modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb:463
     # ./app/models/custom_actions/conditions/role.rb:44:in `flatten'
    @oliverguenther
    oliverguenther committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    98d92b4 View commit details
    Browse the repository at this point in the history

  3. Reload attribute help texts to update previews

    @oliverguenther
    oliverguenther committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1ccb13b View commit details
    Browse the repository at this point in the history

  4. wait for network_idle on logout_spec

    @oliverguenther
    oliverguenther committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    df2ec4e View commit details
    Browse the repository at this point in the history

  5. Fix forum upload spec 

    with turbo: false, the form does not correctly get replaced in the current implementation,
brekaing tests on upload attachment counting.
    @oliverguenther
    oliverguenther committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e8b26ed View commit details
    Browse the repository at this point in the history

  6. Wait for idle

    @oliverguenther
    oliverguenther committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aa62d9c View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/dev' into experiment/enable-turb… 

    …o-drive
    @ulferts
    ulferts committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d5b6f91 View commit details
    Browse the repository at this point in the history

  8. adapt secure_headers patched version

    @ulferts
    ulferts committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6fe6bf0 View commit details
    Browse the repository at this point in the history

  9. wait for network on user index tests

    @ulferts
    ulferts committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4ed3468 View commit details
    Browse the repository at this point in the history

  10. fix spec by adding a success flash semaphore

    @ulferts
    ulferts committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7e70cb5 View commit details
    Browse the repository at this point in the history

  11. properly destroy form configuration component

    @ulferts
    ulferts committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7c3f6a9 View commit details
    Browse the repository at this point in the history