Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] add file/folder creation and list sharedByMe of link shares #9150

Merged
merged 6 commits into from
May 17, 2024
Merged

[tests-only] add file/folder creation and list sharedByMe of link shares #9150

merged 6 commits into from
May 17, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 14, 2024 •
edited
Loading

Description

Extended file/folder creation API tests
Added list sharedByMe of link shares

Taken from owncloud/web#10898

Scenario: sharer lists the file/folder link share (Personal space)
Scenario: sharer lists the link shares of same name files/folders (Personal space)
Scenario: sharer lists the link shares of a file/folder after deleting one link share (Personal space)
Scenario: sharer lists the file/folder link share (Project space)
Scenario: sharer lists the link shares of same name files/folders (Project space)
Scenario: sharer lists the link shares of a file/folder after deleting one link share (Project space)

# file/folder creation
Scenario Outline: try to create file and folder with '.', '..' and 'empty'
Scenario Outline: create a folder with dots in the name

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🖐️

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this May 14, 2024
@saw-jan saw-jan changed the title [tests-only] extend file folder creation [tests-only] add file/folder creation and list sharedByMe of link shares May 14, 2024
This was referenced May 14, 2024
Closed
Merged
@saw-jan saw-jan marked this pull request as ready for review May 14, 2024 06:33
@saw-jan saw-jan force-pushed the tests/extend-file-folder-creation branch from b9f6d3f to 065ecf3 Compare May 14, 2024 11:22
@saw-jan saw-jan force-pushed the tests/extend-file-folder-creation branch from e2b55e4 to 4b65a49 Compare May 17, 2024 06:54
ScharfViktor
ScharfViktor reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other looks good 👍

tests/acceptance/features/coreApiWebdavProperties/createFileFolder.feature Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan requested a review from ScharfViktor May 17, 2024 07:46
@saw-jan saw-jan merged commit 590a40d into master May 17, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/extend-file-folder-creation branch May 17, 2024 08:34
ownclouders pushed a commit that referenced this pull request May 17, 2024
@saw-jan
[tests-only] add file/folder creation and list sharedByMe of link sha…
96d24e3 
…res (#9150)

* test: add more edge-case tests for file/folder creation

* test: add list sharedByMe tests for link shares

* test: fix tests

* test: list sharedByMe of drive link share

* test: add issue tag

* test: split scenario
ownclouders pushed a commit that referenced this pull request May 18, 2024
@saw-jan
[tests-only] add file/folder creation and list sharedByMe of link sha…
5aae1fc 
…res (#9150)

* test: add more edge-case tests for file/folder creation

* test: add list sharedByMe tests for link shares

* test: fix tests

* test: list sharedByMe of drive link share

* test: add issue tag

* test: split scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @ScharfViktor