-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] extend link share e2e test and remove acceptance suites #10898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
Quality Gate passedIssues Measures |
saw-jan
requested review from
grgprarup,
SagarGi,
amrita-shrestha,
S-Panta,
PrajwolAmatya and
ScharfViktor
May 14, 2024 06:54
ScharfViktor
approved these changes
May 14, 2024
@@ -1322,7 +1327,7 @@ export const batchRestoreTrashBinResources = async ( | |||
) | |||
} | |||
|
|||
await Promise.all([waitResponses, page.locator(restoreResourceButton).click()]) | |||
await Promise.all([...waitResponses, page.locator(restoreResourceButton).click()]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
saw-jan
added a commit
that referenced
this pull request
May 14, 2024
…e suites (#10898) * test: remove file/folder creation webUI acceptance test suite * test: extend public link e2e tests and remove acceptance suite * test: spread the waitResponses array * test: fix rebase
7 tasks
saw-jan
added a commit
that referenced
this pull request
May 15, 2024
…e suites (#10898) * test: remove file/folder creation webUI acceptance test suite * test: extend public link e2e tests and remove acceptance suite * test: spread the waitResponses array * test: fix rebase
anon-pradip
pushed a commit
to anon-pradip/web
that referenced
this pull request
May 15, 2024
…e suites (owncloud#10898) * test: remove file/folder creation webUI acceptance test suite * test: extend public link e2e tests and remove acceptance suite * test: spread the waitResponses array * test: fix rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended link share e2e tests for resource creation and deletion by public
Removed file/folder creation and link share webUI acceptance test suites
Some scenarios covered in API test: owncloud/ocis#9150
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes