Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] extend link share e2e test and remove acceptance suites #10898

Merged
merged 4 commits into from
May 14, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 14, 2024

Description

Extended link share e2e tests for resource creation and deletion by public
Removed file/folder creation and link share webUI acceptance test suites

Some scenarios covered in API test: owncloud/ocis#9150

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🖐️

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan marked this pull request as ready for review May 14, 2024 06:53
@@ -1322,7 +1327,7 @@ export const batchRestoreTrashBinResources = async (
)
}

await Promise.all([waitResponses, page.locator(restoreResourceButton).click()])
await Promise.all([...waitResponses, page.locator(restoreResourceButton).click()])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan saw-jan merged commit 5c4302a into master May 14, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/remove-resource-link-suite branch May 14, 2024 08:25
saw-jan added a commit that referenced this pull request May 14, 2024
…e suites (#10898)

* test: remove file/folder creation webUI acceptance test suite

* test: extend public link e2e tests and remove acceptance suite

* test: spread the waitResponses array

* test: fix rebase
saw-jan added a commit that referenced this pull request May 15, 2024
…e suites (#10898)

* test: remove file/folder creation webUI acceptance test suite

* test: extend public link e2e tests and remove acceptance suite

* test: spread the waitResponses array

* test: fix rebase
anon-pradip pushed a commit to anon-pradip/web that referenced this pull request May 15, 2024
…e suites (owncloud#10898)

* test: remove file/folder creation webUI acceptance test suite

* test: extend public link e2e tests and remove acceptance suite

* test: spread the waitResponses array

* test: fix rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants