Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] added e2e test to receive two shares with same name #10488

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[tests-only] added e2e test to receive two shares with same name #10488

merged 3 commits into from
Feb 21, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

Description

In this PR,

  • removed web UI test to accept two shares with same name
  • added e2e test to accept two shares with same name

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@PrajwolAmatya PrajwolAmatya self-assigned this Feb 15, 2024
@PrajwolAmatya PrajwolAmatya mentioned this pull request Feb 15, 2024
Closed
18 tasks
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review February 19, 2024 11:10
saw-jan
saw-jan reviewed Feb 19, 2024
View reviewed changes
tests/e2e/cucumber/features/smoke/shares/share.feature Outdated
Comment on lines 196 to 200
| testfile.txt |
| testfile (1).txt |
# https://github.com/owncloud/ocis/issues/8471
# | test-folder |
# | test-folder (1) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue is only for folder shares?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that works
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue might occur for files as well as in this issue owncloud/ocis#8471.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then will the test get flaky if we keep testfile (1).txt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the shares list for the user is:

testfile.txt
testfile (1).txt
test-folder
test-folder (2)

While i did it manually, the shares list for the user is:

testfile.txt
testfile (3).txt
test-folder
test-folder (1)

Not so sure why we get different results while testing manually and in automation.

saw-jan
saw-jan reviewed Feb 19, 2024
View reviewed changes
tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md
@@ -24,7 +24,3 @@ Other free text and markdown formatting can be used elsewhere in the document if
### [empty subfolder inside a folder to be uploaded is not created on the server](https://github.com/owncloud/web/issues/6348)

- [webUIUpload/upload.feature:43](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L43)

### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the status of this issue? I see it is still open

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned issue doesn't exist on the latest oCIS master. The expected behavior (1) to be added on the second share with same name, and resources can be accessed via propfind. So, that issue is closed now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please, find the API test coverage for that one and if there is none we have to add one

@PrajwolAmatya PrajwolAmatya mentioned this pull request Feb 20, 2024
Open
34 tasks
@ScharfViktor ScharfViktor mentioned this pull request Feb 20, 2024
Merged
3 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the receive-two-share-with-same-name branch 2 times, most recently from 2b3df1d to cea4a1a Compare February 21, 2024 08:29
saw-jan
saw-jan approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 9444050 into master Feb 21, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the receive-two-share-with-same-name branch February 21, 2024 10:23
@S-Panta S-Panta mentioned this pull request Feb 27, 2024
Closed
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@PrajwolAmatya @saw-jan
[tests-only] added e2e test to receive two shares with same name (#10488
862286f 
)

* added e2e test to receive two shares with same name

* removed web UI test related to receiving two shares with same name

* added step to share file with same name
@saw-jan saw-jan mentioned this pull request Mar 5, 2024
Merged
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@PrajwolAmatya @saw-jan
[tests-only] added e2e test to receive two shares with same name (#10488
bbf16e7 
)

* added e2e test to receive two shares with same name

* removed web UI test related to receiving two shares with same name

* added step to share file with same name
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@PrajwolAmatya @saw-jan
[tests-only] added e2e test to receive two shares with same name (#10488
9a2941e 
)

* added e2e test to receive two shares with same name

* removed web UI test related to receiving two shares with same name

* added step to share file with same name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrajwolAmatya @saw-jan @ScharfViktor