create lc finalized header based on finalized block version #14457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspector-Butters
changed the title
3 tasks
rkapka
approved these changes
Sep 30, 2024
Inspector-Butters
deleted the
lc-attested-and-finalized-different-forks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR adds more comprehensive tests for the
core.lightclient.NewLightClientUpdateFromBeaconStatefunction.specifically:
NewLightClientFinalityUpdateFromBeaconStateusing a valid finalized blockNewLightClientFinalityUpdateFromBeaconStateusing a nil finalized blockNewLightClientFinalityUpdateFromBeaconStateusing a valid finalized block in the previous fork of the attested blockNewLightClientUpdateFromBeaconStatefunction to create the finalized header based on the finalized block's version, not the attested block.Which issues(s) does this PR fix?
This PR is needed as part of #12991