Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the naming for utd_ratio #59

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix the naming for utd_ratio #59

merged 1 commit into from
Jun 13, 2024

Conversation

jianlanluo
Copy link
Collaborator

As we are using async update, the old naming utd_ratio doesn't apply anymore. To avoid confusion, we are renaming it to "critic_actor_ratio", the empirical value is set to 4, but can also change to anything that's suitable

@jianlanluo jianlanluo self-assigned this Jun 13, 2024
Copy link
Collaborator

@charlesxu0124 charlesxu0124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jianlanluo jianlanluo merged commit 646b768 into main Jun 13, 2024
1 check passed
@jianlanluo jianlanluo deleted the utd branch June 13, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants