-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9908a9c) # Conflicts: # joint_trajectory_controller/test/test_trajectory_controller.cpp
(cherry picked from commit 8674f2d) # Conflicts: # joint_trajectory_controller/CMakeLists.txt
* Fix time sources and wrong checks in tests * Use time from update-method instead of node clock * Readd test of last command in test_goal_tolerances_fail --------- Co-authored-by: Bence Magyar <[email protected]> (cherry picked from commit 7e13d1d) # Conflicts: # joint_trajectory_controller/test/test_trajectory_actions.cpp
(cherry picked from commit f70c986)
(cherry picked from commit ff6e81d)
* Reject receiving trajectory of last velocity point is non-zero * Update docs * Add tests * Change to parameterized test * Rename parameter * not true -> false --------- Co-authored-by: Bence Magyar <[email protected]> (cherry picked from commit 99b67d7)
(cherry picked from commit 88c3463)
(cherry picked from commit e49c540) # Conflicts: # joint_trajectory_controller/include/joint_trajectory_controller/validate_jtc_parameters.hpp
(cherry picked from commit 259d3d8)
(cherry picked from commit 126b95c) # Conflicts: # joint_trajectory_controller/test/test_trajectory_controller.cpp
github-actions
bot
requested review from
anfemosa,
aprotyas,
bmagyar,
destogl,
malapatiravi and
peterdavidfagan
July 17, 2023 17:42
This was referenced Aug 3, 2023
The only ABI break is the namespace of the generate_parameter_library. |
bmagyar
approved these changes
Aug 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Fix file name for include guard (backport #681) (cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <[email protected]> * Activate AdmittanceControllerTestParameterizedInvalidParameters (#711) (#733) * [JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) (#706) * Enable effort rejection test --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
bmagyar
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Small improvement in remapping (#393) (#724) * Fix file name for include guard (backport #681) (cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <[email protected]> * Activate AdmittanceControllerTestParameterizedInvalidParameters (#711) (#733) * [JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) (#706) * Add state_publish_rate parameter --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #705 done by Mergify.
Cherry-pick of 9908a9c has failed:
Cherry-pick of 8674f2d has failed:
Cherry-pick of 7e13d1d has failed:
Cherry-pick of e49c540 has failed:
Cherry-pick of 126b95c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com