Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 IiifPrint does not split or create relationships #343

Closed
5 tasks
Tracked by #312
laritakr opened this issue Apr 5, 2024 · 6 comments
Closed
5 tasks
Tracked by #312

🐛 IiifPrint does not split or create relationships #343

laritakr opened this issue Apr 5, 2024 · 6 comments

Comments

@laritakr
Copy link
Contributor

laritakr commented Apr 5, 2024

IiifPrint is not splitting appropriately. The purpose of this ticket is to handle PDFs appropriately.

Ref #341

Acceptance Criteria

On a properly configured tenant & work,

  • A work with PDF uploaded through the UI will split & display in UV
  • A work with PDF uploaded through Bulkrax will split & display in UV
  • Child works connect appropriately to the parent work
  • A PDF can be resplit via a button on the file view
  • When a PDF is removed, the derived child works also are removed
@laritakr
Copy link
Contributor Author

laritakr commented Apr 5, 2024

Currently blocked by samvera/hyku#2177

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented May 9, 2024

TODO: LaRita may have a branch to merge, that also updates iiif print to these changes. cc @laritakr

i343-iiif-print-valkyrization

https://github.com/samvera/hyku/pull/2187/files

laritakr added a commit that referenced this issue May 9, 2024
@jillpe
Copy link

jillpe commented May 23, 2024

Blocked: Waiting to be updated in hyku

@laritakr
Copy link
Contributor Author

laritakr commented Jun 6, 2024

samvera/hyku#2210

@laritakr laritakr removed the Blocked label Jun 6, 2024
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jun 13, 2024

QA RESULTS: BLOCKED

Pals knapsack importer is not working.

I first uploaded a csv that were missing headers and the errors did not get reported.

Sample CSV (missing headers) - i347-qa-error.zip

perhaps #status_info needs to be updated to #set_status_info

    def valid_import?
      missing_fields_by_model = records.each_with_object({}) do |record, hash|
        record.compact!
        record.transform_keys!(&:downcase).transform_keys!(&:to_sym)
        missing_fields = missing_fields_for(record)
        hash[record[:model]] = missing_fields if missing_fields.present?
      end

      raise_error_for_missing_fields(missing_fields_by_model) if missing_fields_by_model.keys.present?

      file_paths.is_a?(Array)
    rescue StandardError => e
      importer.set_status_info(e)
      false
    end

After that, I corrected the headers and imported, but get a NoMethodError:

#find is returning false

Sample CSV:

i347-i343-qa.zip

image

image

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jun 17, 2024

QA RESULTS: PASS ✅

Tested on HYKU STAGING

I manually imported a multi page pdf. Set the feature flag to use UV instead of PDF.js. It correctly split the PDF:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants