This repository has been archived by the owner on May 27, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve model.cond with custom materializer #36
Solve model.cond with custom materializer #36
Changes from all commits
9860b69
91f8b1c
937e303
36f07db
56e0b05
fdcded0
15d882c
52956ec
8ddd5bb
ee79d70
402cff4
438a469
f6be15d
784266b
3a1ef9a
90e8247
068c7cc
46f1420
c7d3290
36ed509
9d8add0
28faf64
822c623
ea027a2
cab9750
4039e23
ef99eb4
e59e760
43f77e1
54a0d0b
86f114a
2c8df26
99992c1
6104af0
e180e7a
c2d7687
66f9919
4cc220d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the class declaration inside of another class? This makes reasoning about what goes on a bit challenging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because each class needs to be tied to one specific
factor_storage
object. The class gets instantiated by formulaic, therefore we can only pass a class, rather than an instance.Each class is used only for one formulaic formula and stores the formula-specific metadata in the
factor_storage
object that is tied to it.