Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning for DA function in MrVI #2999

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix warning for DA function in MrVI #2999

merged 1 commit into from
Sep 30, 2024

Conversation

justjhong
Copy link
Contributor

@justjhong justjhong commented Sep 27, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.36%. Comparing base (f1f58b9) to head (02e5cd2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2999      +/-   ##
==========================================
- Coverage   84.81%   84.36%   -0.46%     
==========================================
  Files         167      167              
  Lines       14490    14490              
==========================================
- Hits        12290    12224      -66     
- Misses       2200     2266      +66
Files with missing lines Coverage Δ
src/scvi/external/mrvi/_model.py 7.72% <ø> (ø)

... and 1 file with indirect coverage changes

@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.2 milestone Sep 30, 2024
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Sep 30, 2024
@ori-kron-wis ori-kron-wis merged commit efbbc68 into main Sep 30, 2024
17 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Sep 30, 2024
@justjhong @meeseeksmachine
Backport PR scverse#2999: Fix warning for DA function in MrVI
b179a27
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 30, 2024
Merged
ori-kron-wis pushed a commit that referenced this pull request Sep 30, 2024
@meeseeksmachine @justjhong
Backport PR #2999 on branch 1.2.x (Fix warning for DA function in MrV…
460969f 
…I) (#3001)

Backport PR #2999: Fix warning for DA function in MrVI

Co-authored-by: Justin Hong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canergen canergen Awaiting requested review from canergen

@PierreBoyeau PierreBoyeau Awaiting requested review from PierreBoyeau

Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
scvi-tools 1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@justjhong @ori-kron-wis