Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CUDA fix in decipher #3110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ori-kron-wis
Copy link
Collaborator

@ori-kron-wis ori-kron-wis commented Dec 23, 2024

@justjhong I already fixed one of the tests (but you should review it)

close #3109

@ori-kron-wis ori-kron-wis added cuda tests Run test suite on CUDA on-merge: backport to 1.3.x on-merge: backport to 1.3.x labels Dec 23, 2024
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.3 milestone Dec 23, 2024
@ori-kron-wis ori-kron-wis self-assigned this Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.27%. Comparing base (6ae39a4) to head (013835c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   87.67%   83.27%   -4.40%     
==========================================
  Files         180      180              
  Lines       15187    15187              
==========================================
- Hits        13315    12647     -668     
- Misses       1872     2540     +668     
Files with missing lines Coverage Δ
src/scvi/external/decipher/_model.py 96.11% <100.00%> (ø)

... and 11 files with indirect coverage changes

Copy link
Contributor

@justjhong justjhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this and thanks for squashing the bug! Is the other test fixed as well or should I take a stab at it?

@canergen
Copy link
Member

Hi, I don't think so the test reports where off here, so I restarted them. It's pretty much the same thing with device handling.

@ori-kron-wis
Copy link
Collaborator Author

@justjhong no the other test is failing, I wasnt sure what will be the way to go, please see if you can fix it.
yes it is basically on device handling (cpu and gpu calculation at the same time, but in the trajectory part, which is all cpu)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decipher - CUDA tests failure
3 participants