-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: CUDA fix in decipher #3110
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
- Coverage 87.67% 83.27% -4.40%
==========================================
Files 180 180
Lines 15187 15187
==========================================
- Hits 13315 12647 -668
- Misses 1872 2540 +668
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this and thanks for squashing the bug! Is the other test fixed as well or should I take a stab at it?
Hi, I don't think so the test reports where off here, so I restarted them. It's pretty much the same thing with device handling. |
@justjhong no the other test is failing, I wasnt sure what will be the way to go, please see if you can fix it. |
@justjhong I already fixed one of the tests (but you should review it)
close #3109