FEATURE - Detect tandem duplications with cigar #148
+522
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 98.40% 98.09% -0.32%
==========================================
Files 19 19
Lines 878 944 +66
==========================================
+ Hits 864 926 +62
- Misses 14 18 +4
Continue to review full report at Codecov.
|
Irallia
force-pushed
the
FEATURE/detect_tandem_duplications_with_CIGAR
branch
4 times, most recently
from
a0408ac
to
7c8e74b
Compare
Irallia
force-pushed
the
FEATURE/detect_tandem_duplications_with_CIGAR
branch
5 times, most recently
from
f8e8809
to
5cd7ed5
Compare
Irallia
commented
Aug 30, 2021
| auto & res = *results.begin(); | ||
| // TODO (irallia 17.8.21): The mismatches should give us the opportunity to allow a given amount of errors in the | ||
| // duplication. | ||
| size_t matches = res.score() % 100; |
There was a problem hiding this comment.
! modulo works wierd with negative values!
Irallia
commented
Aug 30, 2021
Comment on lines
+63
to
+82
| * ref AAAACCGCGTAGCGGG----------TACGTAACGGTACG | ||
| * |||||||||||||| |||||||| -> inserted sequence: GCGGGGCGGG | ||
| * read AACCGCGTAGCGGGGCGGGGCGGGTACGTAAC | ||
| * | ||
| * suffix_sequence AAAACCGCGTAGCGGG -> free_end_gaps_sequence1_leading{true}, | ||
| * ||||| free_end_gaps_sequence1_trailing{false} | ||
| * inserted_bases GCGGGGCGGG -> free_end_gaps_sequence2_leading{false}, | ||
| * free_end_gaps_sequence2_trailing{true} | ||
| * -> tandem_dup_count = 3, duplicated_bases = GCGGG | ||
| * | ||
| * Case 2: The duplication (insertion) comes before the matched sequence. | ||
| * ref AAAACCGCGTA----------GCGGGTACGTAACGGTACG | ||
| * ||||||||| ||||||||||||| -> inserted sequence: GCGGGGCGGG | ||
| * read AACCGCGTAGCGGGGCGGGGCGGGTACGTAAC | ||
| * | ||
| * prefix_sequence GCGGGTACGTAACGGTACG -> free_end_gaps_sequence1_leading{false}, | ||
| * ||||| free_end_gaps_sequence1_trailing{true} | ||
| * inserted_bases GCGGGGCGGG -> free_end_gaps_sequence2_leading{true}, | ||
| * free_end_gaps_sequence2_trailing{false} | ||
| * -> tandem_dup_count = 3, duplicated_bases = GCGGG |
There was a problem hiding this comment.
Other Idea:
create suffix tree of the inserted sequence and search for longest common repeated substring without overlap (with errors) and than map this repeated substring (without errors?).
Other input: Burrows Wheeler, occurence table, FM index; reg Expression -> build minimal automat; ZIP Hoffmann code
Irallia
commented
Aug 30, 2021
| */ | ||
| std::tuple<size_t, size_t> align_suffix_or_prefix(auto const & config, | ||
| int32_t const min_length, | ||
| std::span<const seqan3::dna5> & sequence, |
There was a problem hiding this comment.
Suggested change
| std::span<const seqan3::dna5> & sequence, | |
| std::span<const seqan3::dna5> const sequence, |
marehr
reviewed
Aug 31, 2021
| // TODO (irallia 17.8.21): The mismatches should give us the opportunity to allow a given amount of errors in the | ||
| // duplication. | ||
| size_t matches = res.score() % 100; | ||
| size_t mismatches = (res.score() - matches) * (-1); |
There was a problem hiding this comment.
Isn't this the same as:
mismatches = floor(res.score() / 100) * 100;
?
Comment on lines
+22
to
+24
| std::span<seqan3::dna5 const> & sequence, | ||
| std::span<seqan3::dna5 const> & inserted_bases, |
| auto & res = *results.begin(); | ||
| // TODO (irallia 17.8.21): The mismatches should give us the opportunity to allow a given amount of errors in the | ||
| // duplication. | ||
| size_t matches = res.score() % 100; |
Irallia
force-pushed
the
FEATURE/detect_tandem_duplications_with_CIGAR
branch
from
5cd7ed5
to
abbf672
Compare
Irallia
force-pushed
the
FEATURE/detect_tandem_duplications_with_CIGAR
branch
from
abbf672
to
5301059
Compare
Signed-off-by: Lydia Buntrock <[email protected]>
Signed-off-by: Lydia Buntrock <[email protected]>
Irallia
force-pushed
the
FEATURE/detect_tandem_duplications_with_CIGAR
branch
from
5301059
to
4a44217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #166
With this PR we can now detect tandem duplications in the CIGAR string. We only collect tandem duplications with no errors. In a follow up PR, we will allow errors aswell. Thus I wrote some TODOs in the code.