Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Reorganize hpp and cpp files so building time decreases #68

Merged
merged 6 commits into from
Feb 22, 2021
Merged

[INFRA] Reorganize hpp and cpp files so building time decreases #68

merged 6 commits into from
Feb 22, 2021

Conversation

Irallia
Copy link
Collaborator

@Irallia Irallia commented Feb 17, 2021

For the reviewers, go through this PR commit wise, as I moved a lot of files and changed them afterwards.

  • I added pragma once for all header files to ensure that these files are only included once.
  • I replaced all seqan/.../all.hpp includes with the needed ones.
  • I moved as many includes from header files into the corresponding cpp files to shorten the (re)build time.
  • I reorganised some Header Files
  • I created associated cpp files for header files and moved non-template functions into them.

@Irallia Irallia self-assigned this Feb 17, 2021
joergi-w
joergi-w requested changes Feb 17, 2021
View reviewed changes
Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from my side... in general it looks good already!

include/detect_breakends/junction_detection.hpp Show resolved Hide resolved
include/find_deletions/deletion_finding_and_printing.hpp Show resolved Hide resolved
src/detect_breakends/junction_detection.cpp Outdated Show resolved Hide resolved
src/find_deletions/deletion_finding_and_printing.cpp Show resolved Hide resolved
src/structures/aligned_segment.cpp Outdated Show resolved Hide resolved
src/structures/aligned_segment.cpp Show resolved Hide resolved
src/structures/breakend.cpp Outdated Show resolved Hide resolved
src/structures/junction.cpp Outdated Show resolved Hide resolved
src/structures/junction.cpp Outdated Show resolved Hide resolved
src/structures/breakend.cpp Outdated Show resolved Hide resolved
joergi-w
joergi-w reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further comments... Nothing serious, just remarks.

include/structures/aligned_segment.hpp Show resolved Hide resolved
include/structures/aligned_segment.hpp Show resolved Hide resolved
include/structures/cluster.hpp Show resolved Hide resolved
src/structures/aligned_segment.cpp Outdated Show resolved Hide resolved
src/structures/aligned_segment.cpp Outdated Show resolved Hide resolved
src/structures/junction.cpp Outdated Show resolved Hide resolved
@Irallia Irallia mentioned this pull request Feb 18, 2021
Open
5 tasks
joergi-w
joergi-w approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks very good!

eldariont
eldariont approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@eldariont eldariont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Irallia for the hard work on restructuring the code. I went through all commits and am completely happy with this PR. Thanks @joergi-w for the first review which was educational for me (didn't know e.g. of the possibility of fall-through in case statements 🙂 )

@Irallia Irallia force-pushed the INFRA/reorganize_hpp_and_cpp_files_so_building_time_decreases branch from 647c53d to ce3dffb Compare February 22, 2021 10:47
@Irallia Irallia force-pushed the INFRA/reorganize_hpp_and_cpp_files_so_building_time_decreases branch from ce3dffb to 8eb829e Compare February 22, 2021 11:05
@Irallia Irallia merged commit 4c76ea6 into seqan:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldariont eldariont eldariont approved these changes

@joergi-w joergi-w joergi-w approved these changes

Assignees

@Irallia Irallia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Irallia @joergi-w @eldariont