Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Add kebechet schedule, implement class Schedule #58

Merged

Conversation

xtuchyna
Copy link
Member

@xtuchyna xtuchyna commented Dec 1, 2020

Related Issues and Dependencies

This PR implements #48

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Schedule class
schedule_for_kebechet_analysis

Description

Schedule class is there just to have a more compact code - not yet used, waiting for proper methods to be implemented in common.
schedule_for_kebechet_analysis should then schedule workflows (by using -e for specific kebechet related entities) only for repositories that use kebechet

@sesheta sesheta requested a review from KPostOffice December 1, 2020 18:22
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2020
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2020
@todo
Copy link

todo bot commented Dec 4, 2020

use the return value more efficiently to assign only active managers

mi-scheduler/app.py

Lines 118 to 122 in 047475f

# TODO use the return value more efficiently to assign only active managers
Schedule(gh, repositories=[r for r in kebechet_repos.keys()]).schedule_for_kebechet_analysis(kebechet_repos)
if __name__ == "__main__":


This comment was generated by todo based on a TODO comment in 047475f in #58. cc @xtuchyna.

@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2020
@thoth-station thoth-station deleted a comment from todo bot Dec 4, 2020
@thoth-station thoth-station deleted a comment from todo bot Dec 4, 2020
@xtuchyna xtuchyna requested a review from pacospace January 20, 2021 20:34
@xtuchyna
Copy link
Member Author

/approve

@sesheta
Copy link
Member

sesheta commented Jan 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xtuchyna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@sesheta sesheta merged commit 1b52fc9 into thoth-station:master Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants