-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prims Algorithm Tutorial #711
base: main
Are you sure you want to change the base?
Conversation
- Included an overview, the complexities of the algorithm - Explained one leetcode problem in depth (I couldn't find too many and I wanted to leave some for the suggested problems that were simple and similar) - Included two suggested problems. - Highlighted any references used.
Incorporated the requested changes.
Incorporated the requested changes. Do let me know if they're okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the structure is fine. please add one more example with the same structure.
- Added a second example problem for the same.
Added a second example problem, also highlighted the solutions for the problems that had one. |
Made a few modifications to the code, indentation to make it copy-pastable in leetcode
I made a second commit changing a little bit of the indentation and layout of the code to make it directly copy-pastable in leetcode. Do let me know if it's okay! |
Hello! I just wanted to follow up on the PR. |
Ah, got it. Will make sure to do that next time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made necessary changes to run locally
Apologies for the delay, was a bit caught up with work. Made the changes and tested it locally. Seems to be working fine now. |
Hi there! Just wanted to follow up on the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please apply LaTex instead of using backticks.
- for the content, i will review in depth in weekend.
- Changed all backtick highlighting to LaTeX - Modified the introduction to the problems (made it an explanation instead of just listing input and output) - Changed value for TabItems to 'py'
Made the requested changes. My apologies for not checking with the format of things. I think it should be compliant now. |
Hi, just wanted to follow up on the pull request. |
Hi! Just wanted to know if I needed to make any other changes in this. |
@Infonioknight hey sorry for the late update. been a bit busy these months. will try to review on weekend. thanks. |
@wingkwong no worries at all! Do take care. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Suggested Pre-requisites | ||
Before moving on to learn the Prims algorithm, it is suggested that you know what a [Minimum Spanning Tree (MST)](../graph-theory/minimum-spanning-tree.md) is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also work on MST page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try in a bit once work eases up a little. Hope that's okay.
Hey, had a hectic last couple of months. Will go through everything this weekend and make all the necessary changes |
Change Summary
Checklist
If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed and will be closed without notice. Regular contributors (with 10+ PRs) can skip this part.
General
Tutorial
solutionLink
blank.Solutions
## Approach 1: Two Pointers
.