Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ali/umi fifo flex merge #116

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Ali/umi fifo flex merge #116

merged 16 commits into from
Feb 21, 2024

Conversation

azaidy
Copy link
Contributor

@azaidy azaidy commented Feb 13, 2024

This PR Adds merge capability to umi fifo flex.
The FIFO will automatically merge transactions when ODW > IDW.

The PR also adds a reset synchronizer in testbench_fifo_flex.sv.
Additionally, some minor cleanup in test_fifo_flex.py.

@azaidy azaidy requested a review from volkamir February 13, 2024 16:48
umi/testbench/testbench_fifo_flex.sv Outdated Show resolved Hide resolved
umi/rtl/umi_fifo_flex.v Show resolved Hide resolved
@azaidy azaidy requested a review from volkamir February 13, 2024 23:15
Copy link
Contributor

@volkamir volkamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

utils/rtl/umi2tl_np.v Outdated Show resolved Hide resolved
utils/rtl/umi_packet_merge_greedy.v Outdated Show resolved Hide resolved
@azaidy azaidy requested a review from volkamir February 21, 2024 03:12
Copy link
Contributor

@volkamir volkamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the waiver for now. Will revisit.

@volkamir volkamir merged commit bb651b2 into main Feb 21, 2024
11 checks passed
@volkamir volkamir deleted the ali/umi_fifo_flex_merge branch February 21, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants