Full SME(1) instruction support and STREAMING Groups #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnWilkinson
added
enhancement
|
#rerun tests |
FinnWilkinson
force-pushed
the
additional-sme-support
branch
from
531ebd0 to
7974237
Compare
FinnWilkinson
requested review from
dANW34V3R,
jj16791,
JosephMoore25 and
ABenC377
ABenC377
requested changes
Aug 30, 2024
FinnWilkinson
changed the title
jj16791
requested changes
Oct 26, 2024
There was a problem hiding this comment.
Some comments and I agree with several of Alex's comments. I think it would be good to get the ARM SME/SVE loops as part of our functional verification checks to help test these new instructions. I assume it would have to be done somewhere private though (not sure if we already have that guarantee in the upcoming CI/CD pipelines)?
dANW34V3R
reviewed
Oct 28, 2024
dANW34V3R
reviewed
Oct 28, 2024
FinnWilkinson
force-pushed
the
additional-sme-support
branch
from
4ad3b6e to
aa40d88
Compare
FinnWilkinson
force-pushed
the
additional-sme-support
branch
from
91c4336 to
5945bae
Compare
ABenC377
previously approved these changes
Nov 11, 2024
|
Now outdated as STREAMING groups logic removed which was the only cause for slowdown.
|
dANW34V3R
previously approved these changes
Dec 4, 2024
FinnWilkinson
dismissed stale reviews from dANW34V3R and ABenC377
via
0af7abc
ABenC377
previously approved these changes
Dec 5, 2024
jj16791
reviewed
Dec 8, 2024
jj16791
requested changes
Dec 14, 2024
| @@ -585,9 +590,14 @@ RegisterValue vecUMinP(srcValContainer& sourceValues) { | |||
| const T* n = sourceValues[0].getAsVector<T>(); | |||
| const T* m = sourceValues[1].getAsVector<T>(); | |||
|
|
|||
| // Concatenate the vectors | |||
| T temp[2 * I]; | |||
| memcpy(temp, m, sizeof(T) * I); | |||
There was a problem hiding this comment.
Shouldn't m and n be switched here?
There was a problem hiding this comment.
Good spot, only updated maxP to be in-line with HW...
ABenC377
previously approved these changes
Dec 17, 2024
FinnWilkinson
force-pushed
the
additional-sme-support
branch
from
31a3e6b to
c0b2316
Compare
dANW34V3R
previously approved these changes
Dec 18, 2024
…ssion test (B, H, S, D)
…ion test (B, H, S, D)
…n alias and regression tests (B, H, S, D)
…uctions and aliases and regression tests (B, H, S, D)
…regression tests.
FinnWilkinson
dismissed stale reviews from dANW34V3R and ABenC377
via
1232bcc
FinnWilkinson
force-pushed
the
additional-sme-support
branch
from
c0b2316 to
1232bcc
Compare
ABenC377
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements all available SME (version 1) instructions that are contained within LLVM 14.0.5. Specifically, this is Version 2021-06 of the Armv9-A A64 ISA.
No FP16 or BF16 instructions have been supported due to lacking C++17 types. All Quad-Word instruction variants have been emulated using 64-bit data-types.
In addition to this, new STREAMING_SVE and STREAMING_PREDICATE groups have been introduced (along with corresponding decode logic) to allow for a different pipeline / latency configuration for these instructions when SVE Streaming Mode (the context mode which SME instructions are executed in) is enabled. This can allow for a co-processor style implementation of SME to be implemented within SimEng; with additional latency / reduced throughput being configured to mimic an offload penalty, and different execution or LD/STR hardware being modelled for said co-processor compared to the main core.