Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(intersection): relax TTC end margin for vehicles inside intersection based on distance margin #6833

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+40 −13

fix(behavior_velocity_planner): fix uninitialized smoother param

704ebf9
Select commit
Loading
Failed to load commit list.
Draft

feat(intersection): relax TTC end margin for vehicles inside intersection based on distance margin #6833

fix(behavior_velocity_planner): fix uninitialized smoother param
704ebf9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 21, 2024 in 34s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene_intersection_collision.cpp: IntersectionModule::updateObjectInfoManagerCollision

Annotations

Check warning on line 308 in planning/behavior_velocity_intersection_module/src/scene_intersection_collision.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

IntersectionModule::updateObjectInfoManagerCollision increases in cyclomatic complexity from 39 to 43, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_velocity_intersection_module/src/scene_intersection_collision.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 15.30 to 15.70, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis