refactor(autoware_path_distance_calculator): prefix package and namespace with autoware #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
esteve
added
the
tag:run-build-and-test-differential
esteve
force-pushed
the
prefix-path_distance_calculator
branch
from
a9038e6
to
cc57f06
Compare
common/autoware_path_distance_calculator/src/path_distance_calculator.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8085 +/- ##
==========================================
- Coverage 23.76% 23.75% -0.02%
==========================================
Files 1379 1381 +2
Lines 101359 101405 +46
Branches 38522 38529 +7
==========================================
Hits 24086 24086
- Misses 74846 74892 +46
Partials 2427 2427
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
esteve
force-pushed
the
prefix-path_distance_calculator
branch
2 times, most recently
from
b893b41
to
bdd646d
Compare
…pace with autoware Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
prefix-path_distance_calculator
branch
from
bdd646d
to
0950558
Compare
a-maumau
reviewed
Aug 6, 2024
| @@ -1,7 +1,7 @@ | |||
| <launch> | |||
| <arg name="path" default="/planning/scenario_planning/lane_driving/behavior_planning/path"/> | |||
| <arg name="distance" default="~/distance"/> | |||
| <node pkg="path_distance_calculator" exec="path_distance_calculator_node" name="path_distance_calculator"> | |||
| <node pkg="autoware_path_distance_calculator" exec="path_distance_calculator_node" name="path_distance_calculator"> | |||
There was a problem hiding this comment.
I think we need the autoware_ prefix for exec="path_distance_calculator_node" as well, since the executable is named autoware_path_distance_calculator_node in CMakeLists.txt.
esteve
added a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…pace with autoware (autowarefoundation#8085) Signed-off-by: Esteve Fernandez <[email protected]>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…pace with autoware (autowarefoundation#8085) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: xtk8532704 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefix package and namespace with autoware
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.