Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt_scan_matcher): apply interface change of ndt_omp #8124

Conversation

a-maumau
Copy link
Contributor

Description

This PR is to apply the interface change of tier4/ndt_omp#57

This PR needs to be merged with the tier4/ndt_omp#57

Change:

  • from estimate_xy_covariance_by_Laplace_approximation to estimate_xy_covariance_by_laplace_approximation

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 22, 2024
Copy link

github-actions bot commented Jul 22, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me
After the corresponding ndt_omp repository has been modified, I will submit the approve.

@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 6, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.78%. Comparing base (8cc3e49) to head (9e9b0d5).
Report is 10 commits behind head on main.

Files Patch % Lines
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8124      +/-   ##
==========================================
+ Coverage   23.74%   23.78%   +0.03%     
==========================================
  Files        1379     1380       +1     
  Lines      101359   101345      -14     
  Branches    38524    38522       -2     
==========================================
+ Hits        24072    24108      +36     
+ Misses      74835    74772      -63     
- Partials     2452     2465      +13     
Flag Coverage Δ *Carryforward flag
differential 31.21% <0.00%> (?)
total 23.78% <ø> (+0.03%) ⬆️ Carriedforward from 6fb8804

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro merged commit 34c1b8b into autowarefoundation:main Aug 7, 2024
29 of 30 checks passed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…ndation#8124)

match the func name changed in ndt_omp

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…ndation#8124)

match the func name changed in ndt_omp

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants