Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): fix unreadVariable #8370

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unreadVariable warnings.

sensing/autoware_pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp:234:23: style: Variable 'is_twist_valid' is assigned a value that is never used. [unreadVariable]
  bool is_twist_valid = true;
                      ^

sensing/autoware_pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp:235:21: style: Variable 'is_imu_valid' is assigned a value that is never used. [unreadVariable]
  bool is_imu_valid = true;
                    ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <[email protected]>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc August 6, 2024 04:28
Copy link
Contributor

@vividf vividf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vividf vividf added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.42%. Comparing base (a5d77b4) to head (de22b6a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8370      +/-   ##
==========================================
- Coverage   23.73%   19.42%   -4.31%     
==========================================
  Files        1378      135    -1243     
  Lines      101354     9240   -92114     
  Branches    38503     3645   -34858     
==========================================
- Hits        24057     1795   -22262     
+ Misses      74828     7243   -67585     
+ Partials     2469      202    -2267     
Flag Coverage Δ
differential 19.42% <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit 0e54b7e into autowarefoundation:main Aug 9, 2024
29 of 30 checks passed
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Aug 13, 2024
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
@kobayu858 kobayu858 deleted the fix/cppcheck_unreadVariable_sen-1 branch August 21, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants