refactor(localization_component_launch): rename lidar topic #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamato-ando <Yamato ANDO>
This was referenced Dec 5, 2023
YamatoAndo
requested review from
yukkysaito,
KYabuuchi,
RyuYamamoto,
SakodaShintaro,
Motsu-san and
TaikiYamada4
This was referenced Dec 5, 2023
KYabuuchi
approved these changes
Dec 6, 2023
|
@YamatoAndo The file change seems fine to me, but the DCO workflow isn't passed since your commit is not signed up with your e-mail address. Could you check this out? |
This was referenced Dec 13, 2023
sykwer
pushed a commit
to sykwer/autoware_launch
that referenced
this pull request
Jan 3, 2024
…e-launch chore: sync awf/autoware_launch
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
chore: sync upstream
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 3, 2024
chore: sync beta upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rename lidar topic.
/sensing/lidar/<lidar name>/outlier_filtered/pointcloud-->/sensing/lidar/<lidar name>/pointcloudRelated PRs
Merge all Related PRs at the same time.
autowarefoundation/autoware-documentation#491
autowarefoundation/autoware.universe#5781
autowarefoundation/sample_sensor_kit_launch#82
#722
RobotecAI/awsim_sensor_kit_launch#12
autowarefoundation/awf_reference_sensor_kit_launch#7
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.