Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): bubble up feedback capture to objc layer #4659

Conversation

armcknight
Copy link
Member

fixes the last build issue in #4652; #skip-changelog; for #4272

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 90.582%. Comparing base (e79c9fa) to head (6ddc831).
Report is 1 commits behind head on armcknight/feat(feedback)/validate-envelopes.

Files with missing lines Patch % Lines
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 9 Missing ⚠️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% 6 Missing ⚠️
Sources/Sentry/SentryUserFeedbackIntegration.m 0.000% 5 Missing ⚠️
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##           armcknight/feat(feedback)/validate-envelopes     #4659       +/-   ##
==================================================================================
- Coverage                                        90.594%   90.582%   -0.013%     
==================================================================================
  Files                                               623       623               
  Lines                                             71226     71230        +4     
  Branches                                          25995     25972       -23     
==================================================================================
- Hits                                              64527     64522        -5     
- Misses                                             6601      6611       +10     
+ Partials                                             98        97        -1     
Files with missing lines Coverage Δ
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% <0.000%> (ø)
Sources/Sentry/SentryUserFeedbackIntegration.m 41.666% <0.000%> (-20.834%) ⬇️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% <0.000%> (ø)
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <0.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79c9fa...6ddc831. Read the comment docs.

Copy link

github-actions bot commented Dec 21, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.65 ms 1243.33 ms 7.67 ms
Size 22.32 KiB 766.02 KiB 743.71 KiB

Baseline results on branch: armcknight/feat(feedback)/validate-envelopes

Startup times

Revision Plain With Sentry Diff
7c33e26 1231.92 ms 1253.49 ms 21.57 ms

App size

Revision Plain With Sentry Diff
7c33e26 22.32 KiB 765.13 KiB 742.82 KiB

Previous results on branch: armcknight/feat(feedback)/fix-static-pod-lint-take-2

Startup times

Revision Plain With Sentry Diff
d6193da 1226.11 ms 1253.38 ms 27.27 ms

App size

Revision Plain With Sentry Diff
d6193da 22.32 KiB 766.03 KiB 743.71 KiB

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but LGTM.

@armcknight armcknight merged commit eeb4214 into armcknight/feat(feedback)/validate-envelopes Dec 23, 2024
66 of 68 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/fix-static-pod-lint-take-2 branch December 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants