-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): bubble up feedback capture to objc layer #4659
fix(feedback): bubble up feedback capture to objc layer #4659
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat(feedback)/validate-envelopes #4659 +/- ##
==================================================================================
- Coverage 90.594% 90.582% -0.013%
==================================================================================
Files 623 623
Lines 71226 71230 +4
Branches 25995 25972 -23
==================================================================================
- Hits 64527 64522 -5
- Misses 6601 6611 +10
+ Partials 98 97 -1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments but LGTM.
eeb4214
into
armcknight/feat(feedback)/validate-envelopes
fixes the last build issue in #4652; #skip-changelog; for #4272