Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOCUT] OS Distribution Build Failed for sql-3.0.0 #1065

Closed
opensearch-ci-bot opened this issue Nov 10, 2022 · 10 comments
Closed

[AUTOCUT] OS Distribution Build Failed for sql-3.0.0 #1065

opensearch-ci-bot opened this issue Nov 10, 2022 · 10 comments

Comments

@opensearch-ci-bot
Copy link
Collaborator

Received Error: Error building sql, retry with: ./build.sh manifests/3.0.0/opensearch-3.0.0.yml --component sql.
The distribution build for sql has failed.
Please see build log at https://build.ci.opensearch.org/job/distribution-build-opensearch/6445/consoleFull

@Yury-Fridlyand
Copy link
Collaborator

Again?

> Task :opensearch-sql-plugin:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':opensearch-sql-plugin:compileJava'.
> Could not resolve all dependencies for configuration ':opensearch-sql-plugin:compileClasspath'.
   > Conflict(s) found for the following module(s):
       - com.fasterxml.jackson.dataformat:jackson-dataformat-smile between versions 2.14.0 and 2.13.4
       - com.fasterxml.jackson.dataformat:jackson-dataformat-yaml between versions 2.14.0 and 2.13.4
     Run with:
         --scan or
         :opensearch-sql-plugin:dependencyInsight --configuration compileClasspath --dependency com.fasterxml.jackson.dataformat:jackson-dataformat-smile
     to get more insight on how to solve the conflict.

@ohltyler
Copy link
Member

@Yury-Fridlyand #1058 was only merged to 2.4 & 2.x branches - can you frontport to main? That should fix it.

@ohltyler
Copy link
Member

Also, is there a reason this repo's default branch is 2.x? It's the only one in opensearch-project I see this way.

@Yury-Fridlyand
Copy link
Collaborator

Also, is there a reason this repo's default branch is 2.x? It's the only one in opensearch-project I see this way.

#692 (comment)
I think this approach reduces amount of actions and backports we need.

@ohltyler
Copy link
Member

Also, is there a reason this repo's default branch is 2.x? It's the only one in opensearch-project I see this way.

#692 (comment) I think this approach reduces amount of actions and backports we need.

I feel this can cause confusion from contributors when this is the single repo with a different default branch. From my understanding all repos should be aligned with the core branching strategy.

Also the idea with having 3.0 as default, is to ensure that plugins are able to stay up-to-date with breaking changes in 3.0 such that there will be no big surprises when preparing for 3.0 release. Just my thoughts.

@penghuo
Copy link
Collaborator

penghuo commented Nov 14, 2022

Merge 2.x to main failed, #1063, pending on ML commons fix on 3.0.

  [2022-11-14 16:10:05] [autobuild] /home/runner/work/sql/sql/opensearch/src/main/java/org/opensearch/sql/opensearch/planner/physical/MLCommonsOperatorActions.java:248: error: cannot find symbol
  [2022-11-14 16:10:05] [autobuild]             .run(mlinput, arguments)
  [2022-11-14 16:10:05] [autobuild]             ^
  [2022-11-14 16:10:05] [autobuild]   symbol:   method run(MLInput,Map<String,Object>)

@jmazanec15
Copy link
Member

jmazanec15 commented Nov 14, 2022

@penghuo is there a tracking issue in ml-commons?

@ylwu-amzn
Copy link
Contributor

We need to forward port changes in 2.x to main branch. Create an issue to track this opensearch-project/ml-commons#553

peternied added a commit to peternied/opensearch-build that referenced this issue Nov 15, 2022
@penghuo penghuo removed the untriaged label Nov 22, 2022
@penghuo
Copy link
Collaborator

penghuo commented Nov 22, 2022

Still pending on ML commons fix. #1063

This was referenced Nov 30, 2022
@Yury-Fridlyand
Copy link
Collaborator

Can we close this? Build for 3.0.0 pass today: https://build.ci.opensearch.org/job/distribution-build-opensearch/6708/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants