Clarifying rename of AssetsDefinitionFactory-related classes and properties #22251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrockn
changed the title
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
c9624a2 to
f49250b
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
2d16c86 to
d899428
Compare
This was referenced Jun 3, 2024
sryza
approved these changes
Jun 3, 2024
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
f49250b to
45e0e28
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
d899428 to
9d2411e
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
45e0e28 to
3d349fe
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
9d2411e to
1cb1c89
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
3d349fe to
b85de60
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
1cb1c89 to
977ee45
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
b85de60 to
f38b2bf
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
977ee45 to
8ef77bc
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
f38b2bf to
3afca4a
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
8ef77bc to
67fcd85
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
3afca4a to
9c97bf6
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
67fcd85 to
5991ab8
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
9c97bf6 to
01d649c
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
5991ab8 to
e32fef6
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
01d649c to
16662f2
Compare
schrockn
force-pushed
the
multi-asset-sandy-feedback
branch
from
ab77091 to
01c4392
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-true-14
branch
from
16662f2 to
6281cef
Compare
This was referenced Jun 8, 2024
Merged
Closed
Merged
Merged
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…erties (dagster-io#22251) ## Summary & Motivation Various pieces of good feedback raised by @sryza done here to avoid merge conflicts. * More use of `NamedIn` and `NamedOut` rather than raw tuples * outs_by_output_name instead of asset_outs_by_output_name outs_by_output_name instead of asset_outs_by_output_name * ins_by_input_name instead asset_ins_by_input_name ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Various pieces of good feedback raised by @sryza done here to avoid merge conflicts.
NamedInandNamedOutrather than raw tuplesouts_by_output_name instead of asset_outs_by_output_name
How I Tested These Changes
BK