-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort attributes on DecoratorAssetsDefinitionBuilderArgs #22383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2024
Merged
This was referenced Jun 8, 2024
Closed
Merged
schrockn
force-pushed
the
refactor-builder-creation
branch
from
June 9, 2024 17:14
13657b8
to
3ebedaa
Compare
schrockn
force-pushed
the
refactor-builder-creation
branch
from
June 9, 2024 17:15
3ebedaa
to
f9c1ce2
Compare
This was referenced Jun 9, 2024
schrockn
changed the title
sort args
Sort attributes on DecoratorAssetsDefinitionBuilderArgs
Jun 9, 2024
This was referenced Jun 9, 2024
This was referenced Jun 10, 2024
schrockn
force-pushed
the
refactor-builder-creation
branch
from
June 10, 2024 12:08
f9c1ce2
to
2362771
Compare
This was referenced Jun 10, 2024
sryza
approved these changes
Jun 10, 2024
schrockn
force-pushed
the
refactor-builder-creation
branch
from
June 12, 2024 13:35
2362771
to
2df8109
Compare
This was referenced Jun 12, 2024
cmpadden
pushed a commit
that referenced
this pull request
Jun 13, 2024
## Summary & Motivation Trivial. Just sorting the attributes on `DecoratorAssetsDefinitionBuilderArgs` ## How I Tested These Changes BK
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…2383) ## Summary & Motivation Trivial. Just sorting the attributes on `DecoratorAssetsDefinitionBuilderArgs` ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Trivial. Just sorting the attributes on
DecoratorAssetsDefinitionBuilderArgs
How I Tested These Changes
BK