Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lfx-mentorship-2024-September-November] Enhance Karmada controller-manager and schedule testing coverage #5235

Closed
XiShanYongYe-Chang opened this issue Jul 23, 2024 · 9 comments · Fixed by #5388
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@XiShanYongYe-Chang
Copy link
Member

CNCF LFX mentorship
https://github.com/cncf/mentoring/blob/main/programs/lfx-mentorship/2024/03-Sep-Nov/README.md

Mentor: @XiShanYongYe-Chang

What would you like to be added:

Karmada would like to improve the UT coverage of the code to better maintain the quality of the code and reduce the introduction of defects.

Increase the UT coverage rate to 50% to 60% (currently, the UT coverage rate is 28.26% ).

The entire Karmada repository is a bit large for one project, so we will split it into two projects. The current project needs to improve UT coverage in the following directory:

pkg/controllers
pkg/dependenciesdistributor
pkg/descheduler
pkg/detector
pkg/estimator
pkg/scheduler
pkg/resourceinterpreter
pkg/util

The above directories mainly contain the karmada-controller-manager and karmada-scheduler components of Karmada.

I hope that the students who apply for this project can give the UT coverage rate of each directory plan to achieve, we will move towards these specific goals.

Why is this needed:

@yashpandey06
Copy link

Hey @XiShanYongYe-Chang ,hey looks like a great learning ground for me ,I would like to contribute to this issue under LFX Mentorship program.

@Harsh4902
Copy link

@XiShanYongYe-Chang I want to work on this. Can you provide some pretests?

@XiShanYongYe-Chang
Copy link
Member Author

Just for reference: We can get the code coverage of different files under the current master branch from here.

@mani1911
Copy link

mani1911 commented Aug 9, 2024

Hey @XiShanYongYe-Chang this seems apt for me to learn and I would love to contribute to this

@XiShanYongYe-Chang
Copy link
Member Author

Hello everyone, thank you all very much for your active contributions, the Karmada community warmly welcomes everyone to participate in open-source contributions. You can see that the number of our LFX project spots is less than the number of applicants, which means that the final number of selected participants will be quite small. However, I hope everyone can understand that this is not because you are not good enough. On the contrary, being able to actively participate in open-source contributions, you are all very excellent. Therefore, even if you are not selected for this LFX event in the end, please don't be disappointed. There will still be LFX events to apply for in the future, and I hope everyone can continue to participate and pay attention to the Karmada community.

@XiShanYongYe-Chang
Copy link
Member Author

/reopen

@karmada-bot karmada-bot reopened this Aug 22, 2024
@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@XiShanYongYe-Chang
Copy link
Member Author

This task will be tracked by #5470
Thanks all.
/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closing this issue.

In response to this:

This task will be tracked by #5470
Thanks all.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants