-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous integration #29
Conversation
Ja nisam nikada koristio tu akciju samo ovu: Mozemo probati, pa vidjeti kako ide. Ovo su kriticni dijelovi: |
4cdaac5
to
45b5d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jako dobro, svidja mi se ros-tooling/setup-ros
, moguce da je bolji od ros_industrial
Ne svidja mi se ideja da lintere pozivamo van standardnog ROS test sistema. Najekstremnije sto bih uradio je zamjena ament_flake8 sa flake8, ali u samim ROS testovima.
Cak i ament_flake moze da se podesi sa --config
flagom:
--config path The config file (default: /opt/ros/foxy/lib/python3.8/site-packages/ament_flake8/configuration/ament_flake8.ini)
Podrazumjevano podesavanje je:
[flake8]
extend-ignore = C816,D100,D101,D102,D103,D104,D105,D106,D107,D203,D212,D404,I202
import-order-style = google
max-line-length = 99
show-source = true
statistics = true
pa bih samo tu dodao izuzetke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Malo sam te vise iscimao, ali mislim da smo odradili kako treba. Hvala!
Co-authored-by: Darko Lukic <[email protected]>
No description provided.