Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration #29

Merged
merged 24 commits into from
Dec 7, 2021
Merged

Continuous integration #29

merged 24 commits into from
Dec 7, 2021

Conversation

filiparag
Copy link
Member

No description provided.

@filiparag filiparag added the enhancement New feature or request label Dec 1, 2021
@filiparag filiparag self-assigned this Dec 1, 2021
@filiparag filiparag requested a review from lukicdarkoo December 1, 2021 21:44
@filiparag filiparag added devops System automation and configuration and removed enhancement New feature or request labels Dec 1, 2021
@lukicdarkoo
Copy link
Member

Ja nisam nikada koristio tu akciju samo ovu:
https://github.com/ros-industrial/industrial_ci

Mozemo probati, pa vidjeti kako ide. Ovo su kriticni dijelovi:
https://github.com/cyberbotics/webots_ros2/blob/c1b3a055f9b3d931066083e561c3dbee5b386c3a/.github/workflows/test.yml#L16-L17
Trebamo proveriti da li ros-tooling/setup-ros podrzava to

@filiparag filiparag requested a review from lukicdarkoo December 2, 2021 00:22
@filiparag filiparag force-pushed the ci branch 4 times, most recently from 4cdaac5 to 45b5d1b Compare December 2, 2021 16:54
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jako dobro, svidja mi se ros-tooling/setup-ros, moguce da je bolji od ros_industrial

Ne svidja mi se ideja da lintere pozivamo van standardnog ROS test sistema. Najekstremnije sto bih uradio je zamjena ament_flake8 sa flake8, ali u samim ROS testovima.

Cak i ament_flake moze da se podesi sa --config flagom:

  --config path         The config file (default: /opt/ros/foxy/lib/python3.8/site-packages/ament_flake8/configuration/ament_flake8.ini)

Podrazumjevano podesavanje je:

[flake8]
extend-ignore = C816,D100,D101,D102,D103,D104,D105,D106,D107,D203,D212,D404,I202
import-order-style = google
max-line-length = 99
show-source = true
statistics = true

pa bih samo tu dodao izuzetke

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/linter.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Outdated Show resolved Hide resolved
@filiparag filiparag requested a review from lukicdarkoo December 7, 2021 20:02
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Malo sam te vise iscimao, ali mislim da smo odradili kako treba. Hvala!

@filiparag filiparag merged commit 7014a12 into main Dec 7, 2021
@filiparag filiparag deleted the ci branch December 7, 2021 20:03
@filiparag filiparag linked an issue Dec 13, 2021 that may be closed by this pull request
6 tasks
filiparag added a commit that referenced this pull request Jan 10, 2022
@lukicdarkoo lukicdarkoo added this to the 2022.1 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops System automation and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrisati sistemske testove u CI
2 participants