Move outs parameter contruction to InOutMapper #22224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 2, 2024
schrockn
force-pushed
the
aget-multi-asset-refactor-2
branch
from
7159e49 to
96f3fc9
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-3
branch
from
66d9260 to
e2b3c09
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-2
branch
from
96f3fc9 to
e8f87fd
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-3
branch
from
e2b3c09 to
35e6bc9
Compare
schrockn
force-pushed
the
aget-multi-asset-refactor-3
branch
from
35e6bc9 to
2450ae5
Compare
This was referenced Jun 3, 2024
schrockn
changed the title
sryza
approved these changes
Jun 3, 2024
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-ffixnk1rp-elementl.vercel.app Direct link to changed pages: |
schrockn
force-pushed
the
aget-multi-asset-refactor-3
branch
from
2450ae5 to
5e3f929
Compare
This was referenced Jun 8, 2024
Closed
Merged
Merged
salazarm
pushed a commit
that referenced
this pull request
Jun 10, 2024
## Summary & Motivation Continues on the path of decomposing and moving complexity to the mapper. In this case the construction of the `outs` parameter to `AssetsDefinition`. ## How I Tested These Changes BK
This was referenced Jun 10, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation Continues on the path of decomposing and moving complexity to the mapper. In this case the construction of the `outs` parameter to `AssetsDefinition`. ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Continues on the path of decomposing and moving complexity to the mapper. In this case the construction of the
outsparameter toAssetsDefinition.How I Tested These Changes
BK