Standup Notes 2020 03 24

Participants (alphabetical): Allie, Conor, Erik, Jen, John, Kevin, Kushal, Mickael, Nina, Ro

Topics and Call-outs

• 0.2.4 release check-in
  • client/export/svs debs by EOD
  • Jen and Mickael or Kev
• COVID-comms/Stronger warnings on freedom.press/securedrop.org not to leak to us ( https://github.com/freedomofpress/freedom.press/issues/686 )
• No client sync today

Allie

Yesterday:

• Reviewed Kushal's functional test PR
• Responded to John's review on my starring PR
• Fixed conflict between master and PR for removing source object from source widget, this PR is now on hold until https://github.com/freedomofpress/securedrop-client/pull/944 is merged
• Reviewed Nick's PR for fixing the error status bar min size
• Continued to review https://github.com/freedomofpress/securedrop-client/pull/940

Today:

• Dialog PR, merge https://github.com/freedomofpress/securedrop-client/pull/940 before mine so I can fix any rebase conflicts
• Provide multiple PR reviews, if any more progress is made on https://github.com/freedomofpress/securedrop-client/pull/944 then I'll prioritize continuing to review that PR
• Continue work on potentional crashers https://github.com/freedomofpress/securedrop-client/issues/906#issuecomment-601410639

Blockers or Asks: None

Conor

Yesterday:

• Reviewed and merged https://github.com/freedomofpress/securedrop-workstation/pull/501

Today:

• Attempt repro on QA salt failure: https://github.com/freedomofpress/securedrop-workstation/issues/499#issuecomment-602941427
• Testing AV setup

Blockers or Asks: None

Erik

Yesterday:

• Review install docs via fresh install on new hardware
  • Mostly successful but ran into issue with Salt logic provisioning /opt/securedrop/launcher : https://github.com/freedomofpress/securedrop-workstation/issues/499#issuecomment-602941427
• Pilot comms
• UX research prep w/ Nina

Today:

• More QA, docs work
• More pilot comms

Blockers or Asks: Pls come to support sync at 10:30 PDT / 1:30 EDT for update on pilot

Jen

Yesterday:

• Reviewed a few client PRs
• Fixed one of the remaining bugs: https://github.com/freedomofpress/securedrop-client/pull/979 thanks for review john
• Looked into the package reproducibility pre-release item and added a ci job to that end, see: https://github.com/freedomofpress/securedrop-debian-packaging/pull/156

Today:

• this morning was working on the pre-release RPC policy review item, almost done
• otherwise going to help review or help finish in progress work from client/export since those are the remaining areas before release (standing by to re-review 967 on sourcewidget)
• towards end of day, doing the releases

Blockers or Asks:

• none

John

Yesterday:

• bunch of reviews
• fixing #962

Today:

• adding tests to #969 (file size update)
• https://github.com/freedomofpress/securedrop-client/pull/982
• starting on near-term backlog?

Blockers or Asks:

• None

Kev

Yesterday:

• Revise install docs
• Rehearse install w/ Ro

Today:

• Further revisions to docs
• More QA

Blockers or Asks: None

Kushal

Today:

• Tried to reproduce https://github.com/freedomofpress/securedrop-client/issues/900 and could not in a timebox
• reviewed and approved https://github.com/freedomofpress/securedrop-client/pull/981 (Stop selecting source on sync)
• While trying to write a test for https://github.com/freedomofpress/securedrop-client/pull/976 found I am seeing https://github.com/freedomofpress/securedrop-client/issues/956 (sqlite errors) regularly, means we will have to add those flaky test
• https://github.com/freedomofpress/securedrop-client/pull/983 PR for functional test for relogin from offline mode. Tomorrow:

Blockers or Asks:

• None

Mickael

Yesterday:

• Reviewed Jen's changes based on logging audit (logging of filenames)
• QA, noticed some images failing to print Today:
• Continue investigating ^^
• Release help as needed
• Prep for install rehearsal

Blockers or Asks: Anyone have extensive printer experience in Linux? Debugging help w/ above issue appreciated

Nicholas

• Today

  • Investigated Allie's comment on #977 (variable width error messages). Looks like it's caused by padding / minWidth interacting in interesting ways. See comment therein. Happy to fix, but is that pragmatic?
  • Created small PR #982 to fix #973 (horizontal scrollbar in source list).
  • Updated #940 (animate FramelessDialog) to meet all Erik's requirements. Ready for review. Now fixed the rebase...! :-)
  • Have to admit to procrastinating on #944 (with the above) because, ARGH rebasing. Doing that right now and will finish in the morning.

• Blockers / Asks

  • None
  • More for my todo list please.
  • Penultimate day tomorrow!

Nina

Yesterday:

Today:

Blockers or Asks:

Ro

Yesterday:

• Prod install dress rehearsal: yay!
• meeting with DST folks from AI, HRW
• Misc support tasks
• Wrote up comments on Zoom per Harlo

Today:

• NICAR contact followup re secure tipline workflow/SD (2pm)
• Support tasks
• Meetings
• workstation docs screenshots now that I am on prod

Blockers or Asks: